Last modified: 2014-06-09 06:18:02 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T63610, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 61610 - LiquidThreads should pass jshint
LiquidThreads should pass jshint
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
LiquidThreads (Other open bugs)
master
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: jshint
  Show dependency treegraph
 
Reported: 2014-02-20 13:37 UTC by Antoine "hashar" Musso (WMF)
Modified: 2014-06-09 06:18 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Antoine "hashar" Musso (WMF) 2014-02-20 13:37:55 UTC
jshint reports failure on javascript files and should be fixed. Whenever this is done, one can make the jslint job to be voting by editing integration/zuul-config.git layout.yaml file and remove the line that make the jslint job to be non voting.
Comment 1 Aditya Chaturvedi 2014-03-26 17:05:46 UTC
Hi, I have been looking into this bug. I see JShint producing many warnings on the js files but no errors in particular ( except undefined variables, which i assume work fine when all files are used together ). For some fixes I think I need to change rules in the jshintrc. Is that allowed?
Comment 2 Gerrit Notification Bot 2014-03-26 21:59:40 UTC
Change 121257 had a related patch set uploaded by Adi.iiita:
LiquidThreads should pass jshint

https://gerrit.wikimedia.org/r/121257
Comment 3 Gerrit Notification Bot 2014-03-28 01:03:00 UTC
Change 121257 merged by jenkins-bot:
LiquidThreads should pass jshint

https://gerrit.wikimedia.org/r/121257
Comment 4 Gerrit Notification Bot 2014-03-28 16:31:33 UTC
Change 121688 had a related patch set uploaded by Jforrester:
Make jshint voting for LiquidThreads

https://gerrit.wikimedia.org/r/121688
Comment 5 Gerrit Notification Bot 2014-03-28 16:39:47 UTC
Change 121688 merged by jenkins-bot:
Make jshint voting for LiquidThreads

https://gerrit.wikimedia.org/r/121688
Comment 6 Antoine "hashar" Musso (WMF) 2014-03-28 16:40:29 UTC
Zuul updated. Thank you everyone!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links