Last modified: 2014-10-04 13:43:33 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T63606, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 61606 - InputBox should pass jshint
InputBox should pass jshint
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
InputBox (Other open bugs)
master
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: jshint
  Show dependency treegraph
 
Reported: 2014-02-20 13:35 UTC by Antoine "hashar" Musso (WMF)
Modified: 2014-10-04 13:43 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Antoine "hashar" Musso (WMF) 2014-02-20 13:35:53 UTC
jshint reports failure on javascript files and should be fixed. Whenever this is done, one can make the jslint job to be voting by editing integration/zuul-config.git layout.yaml file and remove the line that make the jslint job to be non voting.
Comment 1 Gerrit Notification Bot 2014-04-07 14:59:05 UTC
Change 120487 had a related patch set uploaded by 01tonythomas:
Adding a JS Class to inputBox to grey out Submit button.

https://gerrit.wikimedia.org/r/120487
Comment 2 Rainer Rillke @commons.wikimedia 2014-04-07 15:41:56 UTC
(In reply to Antoine "hashar" Musso from comment #0)
What does JSHINT complain about and *where*? There is not a single JavaScript file in the repo currently [1]. Only JSON. Please be more specific.

[1] https://github.com/wikimedia/mediawiki-extensions-InputBox/tree/b85c6688
Comment 3 Gerrit Notification Bot 2014-04-11 12:39:03 UTC
Change 125393 had a related patch set uploaded by Hashar:
Make mwext-InputBox-jslint voting

https://gerrit.wikimedia.org/r/125393
Comment 4 Gerrit Notification Bot 2014-04-11 12:39:31 UTC
Change 125393 merged by jenkins-bot:
Make mwext-InputBox-jslint voting

https://gerrit.wikimedia.org/r/125393
Comment 5 Antoine "hashar" Musso (WMF) 2014-04-11 12:40:39 UTC
(In reply to Rainer Rillke @commons.wikimedia from comment #2)
> What does JSHINT complain about and *where*? There is not a single
> JavaScript file in the repo currently [1]. Only JSON. Please be more
> specific.
> 
> [1] https://github.com/wikimedia/mediawiki-extensions-InputBox/tree/b85c6688

I have mass filled bugs for any extension that had the jslint job not voting. I havent looked closely at each extension :-]

Since there is no javascript I have made the jslint job voting. The job also lint the i18n json files  :-]

Thanks for the feedback!
Comment 6 Gerrit Notification Bot 2014-10-04 13:43:33 UTC
Change 120487 merged by jenkins-bot:
Adding a JS Class to inputBox to grey out Submit button.

https://gerrit.wikimedia.org/r/120487

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links