Last modified: 2014-10-17 11:47:42 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T63593, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 61593 - CodeReview should pass jshint
CodeReview should pass jshint
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CodeReview (Other open bugs)
master
All All
: Low normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: jshint
  Show dependency treegraph
 
Reported: 2014-02-20 13:27 UTC by Antoine "hashar" Musso (WMF)
Modified: 2014-10-17 11:47 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Antoine "hashar" Musso (WMF) 2014-02-20 13:27:28 UTC
jshint reports failure on javascript files and should be fixed. Whenever this is done, one can make the jslint job to be voting by editing integration/zuul-config.git layout.yaml file and remove the line that make the jslint job to be non voting.
Comment 1 Gerrit Notification Bot 2014-08-05 09:44:19 UTC
Change 151829 had a related patch set uploaded by Hashar:
Pass jshint

https://gerrit.wikimedia.org/r/151829
Comment 2 Gerrit Notification Bot 2014-08-05 19:05:43 UTC
Change 151829 merged by jenkins-bot:
Pass jshint

https://gerrit.wikimedia.org/r/151829
Comment 3 Andre Klapper 2014-10-17 11:47:42 UTC
Patch was merged - assuming this bug is FIXED. If that is not the case: Please reopen and elaborate what is left to do here to get this report fixed.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links