Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T63592, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 61592 - CodeEditor should pass jshint

Summary:	CodeEditor should pass jshint

Status: RESOLVED FIXED Product: MediaWiki extensions Classification: Unclassified Component: CodeEditor (Other open bugs) Version: master Hardware: All All Importance: Normal normal (vote) Target Milestone: --- Assigned To: Nobody - You can work on this! URL: Whiteboard: Keywords: Depends on: Blocks: jshint   Show dependency tree / graph		Reported: 2014-02-20 13:27 UTC by Antoine "hashar" Musso (WMF) Modified: 2014-03-26 08:08 UTC (History) CC List: 1 user (show) brion See Also: Web browser: --- Mobile Platform: --- Assignee Huggle Beta Tester: ---

Attachments Add an attachment (proposed patch, testcase, etc.)

Description Antoine "hashar" Musso (WMF) 2014-02-20 13:27:05 UTC jshint reports failure on javascript files and should be fixed. Whenever this is done, one can make the jslint job to be voting by editing integration/zuul-config.git layout.yaml file and remove the line that make the jslint job to be non voting. Comment 1 Gerrit Notification Bot 2014-03-25 22:19:34 UTC Change 120954 had a related patch set uploaded by TheDJ: CodeEditor now passes jslint, so make it voting https://gerrit.wikimedia.org/r/120954 Comment 2 Gerrit Notification Bot 2014-03-26 08:06:58 UTC Change 120954 merged by jenkins-bot: CodeEditor now passes jslint, so make it voting https://gerrit.wikimedia.org/r/120954 Comment 3 Antoine "hashar" Musso (WMF) 2014-03-26 08:08:43 UTC Thank you for the code hygiene!