Last modified: 2014-06-21 19:58:02 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 60846 - Deprecate Skin::bottomScripts(), move use of SkinAfterBottomScripts hook to OutputPage::getBottomScripts()
Deprecate Skin::bottomScripts(), move use of SkinAfterBottomScripts hook to O...
Status: NEW
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
All All
: Normal normal with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
Depends on:
Blocks: code_quality
  Show dependency treegraph
Reported: 2014-02-04 20:53 UTC by Mark A. Hershberger
Modified: 2014-06-21 19:58 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Description Mark A. Hershberger 2014-02-04 20:53:41 UTC
Ran into this at [[mw:Thread:Project:Support desk/How to get Piwik code into MobileFrontend?]] and, as a result found this comment right above where the hook is called:

  // TODO and the suckage continues. This function is really just a wrapper around
  // OutputPage::getBottomScripts() which takes a Skin param. This should be
  // cleaned up at some point

Could deprecating Skink::bottomScripts(), and moving the use of the SkinAfterBottomScripts hook to OutputPage::getBottomScripts() fix this?
Comment 1 Mark A. Hershberger 2014-02-05 15:02:32 UTC
This doesn't really change functionality and it fixes a problem with some extensions (interaction of MobileFrontend and Piwik in this case.

If it is ok, I'd like to target the next 1.22 point release.
Comment 2 Mark A. Hershberger 2014-06-21 19:58:02 UTC
Removing target milestone that was in the past.

If you want this in a specific release, have a good reason AND you are willing to find resources to fix this bug, feel free to change it to something appropriate.

Note You need to log in before you can comment on or make changes to this bug.