Last modified: 2014-02-02 19:42:52 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T62658, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 60658 - LocalisationCache::readPHPFile should suppress warnings around ini_set
LocalisationCache::readPHPFile should suppress warnings around ini_set
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Internationalization (Other open bugs)
unspecified
All All
: Normal normal (vote)
: 1.23.0 release
Assigned To: Jacob Clark
: easy
Depends on:
Blocks: 1965
  Show dependency treegraph
 
Reported: 2014-01-31 00:42 UTC by Bawolff (Brian Wolff)
Modified: 2014-02-02 19:42 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Bawolff (Brian Wolff) 2014-01-31 00:42:53 UTC
Some people have ini_set disabled, which sucks but we can't do anything about it. Having the ini_set call fail for disabling apc isn't that big a deal, so we should probably just hide the warning.

So need to put wfSuppressWarnings() before the ini_set call, and wfRestoreWarnings() after the ini_set call in LocalisationCache::readPHPFile
Comment 1 Jacob Clark 2014-02-01 10:55:21 UTC
Hi, I'd love to pick this bug up. Could it be assigned to me?

Jacob Clark.
Comment 2 Jacob Clark 2014-02-01 15:32:27 UTC
This is now in gerrit awaiting code review: https://gerrit.wikimedia.org/r/#/c/110693/
Comment 3 Jesús Martínez Novo (Ciencia Al Poder) 2014-02-02 19:42:52 UTC
Gerrit change #110693 has been merged.

Please, mention the bug in the commit message next time so it gets synced  automatically in bugzilla.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links