Last modified: 2014-01-27 20:18:45 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T62408, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 60408 - Enable global AbuseFilters for all small wikis
Enable global AbuseFilters for all small wikis
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Site requests (Other open bugs)
wmf-deployment
All All
: Highest enhancement with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
: shell
Depends on:
Blocks: SWMT 44975
  Show dependency treegraph
 
Reported: 2014-01-24 22:28 UTC by Marius Hoch
Modified: 2014-01-27 20:18 UTC (History)
15 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Marius Hoch 2014-01-24 22:28:20 UTC
We have global AbuseFilters running on a couple of small and mid sized wikis for almost a year and all problems which turned up have been fixed.

Because of that, we should enable global AbuseFilters on all small wikis (https://noc.wikimedia.org/conf/small.dblist) in order to better fight common abuse cases like spam bots.
Comment 1 Kunal Mehta (Legoktm) 2014-01-24 22:29:19 UTC
+1
Comment 2 Gerrit Notification Bot 2014-01-24 22:29:44 UTC
Change 109435 had a related patch set uploaded by Hoo man:
Enable global AbuseFiters for all small wikis

https://gerrit.wikimedia.org/r/109435
Comment 3 Gerrit Notification Bot 2014-01-25 03:55:51 UTC
Change 109435 merged by jenkins-bot:
Enable global AbuseFiters for all small wikis

https://gerrit.wikimedia.org/r/109435
Comment 4 billinghurst 2014-01-25 09:49:48 UTC
Are you planning an announcement, a discussion, or some sort of communication with the wikis that are impacted?

[Noting that the impact is minimal as at this stage as only stewards can add a global filter, and that they are monitoring filters only.]
Comment 5 billinghurst 2014-01-25 10:13:32 UTC
Just looking through the list, it would seem to include at least five private wiki. Similarly I believe that I can see what seems to be at least one closed wiki.

I would hope that the imposed list would not include the private or closed wikis. Is there a need for a cleaned up list rather than a generic small wikis?
Comment 6 billinghurst 2014-01-25 10:14:49 UTC
Oh, and I see chapter wikis, and not certain that these should be imposed upon without reference to their committees of management. We just host, not manage (is my understanding).
Comment 7 Nemo 2014-01-25 13:39:03 UTC
Yes, probably needs a followup patch to set it false for all private, closed, fishbowl and wikimedia wikis.
Comment 8 Marius Hoch 2014-01-25 16:08:39 UTC
(In reply to comment #7)
> Yes, probably needs a followup patch to set it false for all private, closed,
> fishbowl and wikimedia wikis.

Please tell me where the problem is with that. Please keep in mind that global filters should only be used for clear cases, so that they should be fine for all wikis. Performance isn't an issue, btw.
Comment 9 Trijnstel 2014-01-25 16:26:33 UTC
Can't the global abusefilters be enabled on 'all' wikis? I mean, it's surely useful to have it enabled on all small wikis, but it's certainly even more to have it enabled on all wikis. Or do we need a RFC for that?
Comment 10 Marius Hoch 2014-01-25 16:44:59 UTC
(In reply to comment #9)
> Can't the global abusefilters be enabled on 'all' wikis? I mean, it's surely
> useful to have it enabled on all small wikis, but it's certainly even more to
> have it enabled on all wikis. Or do we need a RFC for that?

There's a bug with condition limits (which we AFAIS don't have in Bugzilla) which blocks that for now, but we certainly plan to do that in the near future.
Comment 11 Marius Hoch 2014-01-25 16:46:58 UTC
This isn't the place to discuss this, btw... This is solely about small wikis.
Comment 12 billinghurst 2014-01-26 00:52:12 UTC
(In reply to comment #8)
> (In reply to comment #7)
> > Yes, probably needs a followup patch to set it false for all private, closed,
> > fishbowl and wikimedia wikis.
> 
> Please tell me where the problem is with that. Please keep in mind that
> global
> filters should only be used for clear cases, so that they should be fine for
> all wikis. Performance isn't an issue, btw.

1) Private wikis are private wikis, and there is absolutely no conditions that metawiki should be filtering their content. NONE.
2) Private wikis are private wikis, and meta filters are not private so hits will show in meta logs. Therefore not private, toally inappropriate, and the content of the filter is not relevant.
3) Wikimedia wikis are not ours, we just host them, so we don't make the decision to filter them without their consent, or at least the invitation. Totally presumptive.
Comment 13 billinghurst 2014-01-26 01:04:29 UTC
This has been implemented, when it is clearly in discussion. Please roll this back, it should not be in the wild at this point.
Comment 14 Gerrit Notification Bot 2014-01-26 03:57:54 UTC
Change 109498 had a related patch set uploaded by Hoo man:
Disable global AbuseFilter for private/fishbowl wikis

https://gerrit.wikimedia.org/r/109498
Comment 15 Marius Hoch 2014-01-26 04:14:57 UTC
(In reply to comment #12)
> 2) Private wikis are private wikis, and meta filters are not private so hits
> will show in meta logs. Therefore not private, toally inappropriate, and the
> content of the filter is not relevant.
Right... thus I've uploaded a follow-up which will fix that.
> 3) Wikimedia wikis are not ours, we just host them, so we don't make the
> decision to filter them without their consent, or at least the invitation.
> Totally presumptive.
This depends on how we judge global filters... I guess this needs to be discussed.
Comment 16 Gerrit Notification Bot 2014-01-27 18:35:05 UTC
Change 109498 merged by jenkins-bot:
Disable global AbuseFilter for private/fishbowl wikis

https://gerrit.wikimedia.org/r/109498
Comment 17 Nemo 2014-01-27 20:18:45 UTC
And deployed, thanks Hoo and Reedy.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links