Last modified: 2014-11-19 13:39:49 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 60295 - Namespace mw.MwEmbedSupport methods
Namespace mw.MwEmbedSupport methods
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
TimedMediaHandler (Other open bugs)
master
All All
: Normal normal (vote)
: ---
Assigned To: Michael Dale
:
Depends on:
Blocks: code_quality
  Show dependency treegraph
 
Reported: 2014-01-21 18:26 UTC by Matthew Flaschen
Modified: 2014-11-19 13:39 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Matthew Flaschen 2014-01-21 18:26:14 UTC
mw.MwEmbedSupport.js has a large number of methods directly on the mw object.

Several of these are general-sounding (mw.ready, mw.load, mw.inherit), so they can be initially confused with core methods.  Others are specific to MwEmbedSupport (e.g. getEmbedPlayerPath), but just shouldn't be on the main object.

I think these should be moved to mw.mwEmbedSupport or somewhere else appropriate.
Comment 1 Derk-Jan Hartman 2014-11-19 13:39:49 UTC
Some of them I confused several times over the past 3 days. Some of them don't even have namespacing over their RL module names.

On my list of 'todos at some point'. biggest problem is that I'm not really familiar with the Kaltura side of this, so i don't really know what would break their setup.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links