Last modified: 2014-02-15 13:28:14 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T61125, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 59125 - Remove SqlBagOStuff::createTables
Remove SqlBagOStuff::createTables
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.23.0
All All
: Low enhancement (vote)
: ---
Assigned To: Tony Thomas
:
Depends on:
Blocks: code_quality
  Show dependency tree / graph
 
Reported: 2013-12-30 17:24 UTC by db [inactive,noenotif]
Modified: 2014-02-15 13:28 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description db [inactive,noenotif] 2013-12-30 17:24:26 UTC 
The method SqlBagOStuff::createTables has the comment "Create shard tables. For use from eval.php.", sounds not like something which is needed any more? (at this location)

Or at least remove the version check for mysql 4.1.0 because at the moment 5.0.2 or later is supported
Comment 1 Gerrit Notification Bot 2014-01-28 10:04:45 UTC 
Change 109859 had a related patch set uploaded by 01tonythomas:
Removed version check for mysql 4.1.0 from SqlBahOStuff::createTables

https://gerrit.wikimedia.org/r/109859
Comment 2 Gerrit Notification Bot 2014-01-28 19:18:01 UTC 
Change 109859 merged by jenkins-bot:
Removed version check for mysql 4.1.0 from SqlBahOStuff::createTables

https://gerrit.wikimedia.org/r/109859
Comment 3 db [inactive,noenotif] 2014-02-15 13:28:14 UTC 
version check is enough, when the method is still needed, so marking as fixed
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links