Last modified: 2013-12-21 06:02:28 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T60610, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 58610 - Score constructs an FSBackend in a deprecated fashion


Summary:	Score constructs an FSBackend in a deprecated fashion

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	Score (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Low minor (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:	http://www.google-melange.com/gci/tas...
Whiteboard:
Keywords:	easy

Depends on:
Blocks:	code_quality
	Show dependency tree / graph

Reported:	2013-12-18 00:28 UTC by Bawolff (Brian Wolff)
Modified:	2013-12-21 06:02 UTC (History)
CC List:	8 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Bawolff (Brian Wolff) 2013-12-18 00:28:51 UTC

Deprecated: Use of FileBackend::__construct called without "wikiID". was deprecated in MediaWiki 1.23. [Called from FileBackendStore::__construct in /var/www/w/git/includes/filebackend/FileBackendStore.php at line 68] in /var/www/w/git/includes/debug/Debug.php on line 301

Deprecated: Use of FileBackend::__construct called with non-object "lockManager". was deprecated in MediaWiki 1.23. [Called from FileBackendStore::__construct in /var/www/w/git/includes/filebackend/FileBackendStore.php at line 68] in /var/www/w/git/includes/debug/Debug.php on line 301

-----

Possible gci bug. Needs to modify Score::getBackend(), so that the default config doesn't create a new FSFileBackend object without specifying wikiID and a lockManager. The appropriate values are probably just wfWikiId() and new NullLockManager( array() ) respectively.

Comment 1 Aaron Schulz 2013-12-18 00:31:28 UTC

(In reply to comment #0)

> Possible gci bug. Needs to modify Score::getBackend(), so that the default
> config doesn't create a new FSFileBackend object without specifying wikiID
> and
> a lockManager. The appropriate values are probably just wfWikiId() and new
> NullLockManager( array() ) respectively.

Yep

Comment 2 Quim Gil 2013-12-18 16:48:05 UTC

(In reply to comment #0)
> Possible gci bug.

Created. Note that we rely on you for support and review. Thank you!

Comment 3 Bawolff (Brian Wolff) 2013-12-18 19:02:57 UTC

(In reply to comment #2)
> (In reply to comment #0)
> > Possible gci bug.
> 
> Created. Note that we rely on you for support and review. Thank you!

For any GCI students reading this, you also have to set $wgDevelopmentWarnings = true; in your LocalSettings.php to see the warnings mentioned above.

Comment 4 Gerrit Notification Bot 2013-12-21 05:43:26 UTC

Change 103088 had a related patch set uploaded by Theopolisme:
Fix depreciation warnings in FileBackend construction

https://gerrit.wikimedia.org/r/103088

Comment 5 Gerrit Notification Bot 2013-12-21 06:02:07 UTC

Change 103088 merged by jenkins-bot:
Fix depreciation warnings in FileBackend construction

https://gerrit.wikimedia.org/r/103088

Note You need to log in before you can comment on or make changes to this bug.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links