Last modified: 2014-02-21 23:14:13 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T60349, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 58349 - Graph of pending reviews in Gerrit shows wrong data
Graph of pending reviews in Gerrit shows wrong data
Status: RESOLVED WONTFIX
Product: Analytics
Classification: Unclassified
Tech community metrics (Other open bugs)
unspecified
All All
: High normal
: ---
Assigned To: Alvaro
:
Depends on:
Blocks: 37463
  Show dependency treegraph
 
Reported: 2013-12-11 20:51 UTC by Quim Gil
Modified: 2014-02-21 23:14 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Quim Gil 2013-12-11 20:51:27 UTC
The "pending" graph at http://korma.wmflabs.org/browser/scr.html shows a growth of pending Gerrit reviews that reaches a maximum of 38360 in February 2013, then drops to 886 in March.

The data must be reviewed. Anything above, say, 2000 pending reviews seems totally unrealistic, leave alone anything on the range of 30k open reviews.
Comment 1 Alvaro 2014-01-22 11:49:18 UTC
Using ssh interface we have wrong data about the changes in the review process. For example:

https://gerrit.wikimedia.org/r/#/c/51369/

From the web interface the +2 change is on Feb 28, 2013.
But using the ssh interface:

acs@lenovix:~$ ssh -p 29418 gerrit.wikimedia.org gerrit query --format=JSON 51369 --all-approvals
...
"type":"Code-Review",
               "description":"Code-Review",
               "value":"2",
               "grantedOn":1364577872,
...
acs@lenovix:~$ LANG= date -ud @1364577872
Fri Mar 29 17:24:32 UTC 2013

This problem is fixed after 2013-04. This is why all graphs that needs changes data should start from 2013-04.
Comment 2 Quim Gil 2014-01-22 17:54:51 UTC
Chad, are you aware of his problem of wrong Gerrit data provided via ssh, and do you see any possibility to fix it?

Otherwise we can solve this as WONTFIX and simply start the Gerrit review metrics from 2013-04 onward, where this problem doesn't exist.
Comment 3 Quim Gil 2014-02-21 23:14:13 UTC
(In reply to Quim Gil from comment #2)
> Otherwise we can solve this as WONTFIX and simply start the Gerrit review
> metrics from 2013-04 onward, where this problem doesn't exist.

This.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links