Last modified: 2013-12-12 01:01:57 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T60318, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 58318 - VisualEditor: Pasting a table with a caption breaks fixUpInsertion


Summary:	VisualEditor: Pasting a table with a caption breaks fixUpInsertion

Status:	RESOLVED FIXED

Product:	VisualEditor
Classification:	Unclassified
Component:	Editing Tools (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	High normal
Target Milestone:	VE-deploy-2013-12-12
Assigned To:	Ed Sanders

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	ve-richpaste
	Show dependency tree / graph

Reported:	2013-12-11 08:59 UTC by Derk-Jan Hartman
Modified:	2013-12-12 01:01 UTC (History)
CC List:	8 users (show)

See Also:
Web browser:	Apple Safari
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Derk-Jan Hartman 2013-12-11 08:59:55 UTC

Safari 7

Copy on https://www.mediawiki.org/wiki/VisualEditor?veaction=edit

From and including the header Timeline, up to the paragraph before "Notes" headline (including the table).

Past in an empty surface:

[Error] TypeError: 'undefined' is not an object (evaluating 'source.clone')
	copy (undefined, line 3)
	getClonedElement
	fixupInsertion
	fixupInsertion
	newFromDocumentInsertion
	afterPaste
	proxy (load.php, line 10)

Comment 1 Ed Sanders 2013-12-11 15:13:07 UTC

The problem here is that fixUpInsertion is deciding you can't put a table in a paragraph but not resolving properly.

Comment 2 Ed Sanders 2013-12-11 15:15:00 UTC

More detail: the problem is caused by ContentEditable (surprise). When you paste a table into an empty paragraph, the paragraph is *completely* deleted, which the paste context comparer can't currently deal with.

Comment 3 Ed Sanders 2013-12-11 15:31:30 UTC

Part of this appears to be caused by table captions. Investigating.

Comment 4 Gerrit Notification Bot 2013-12-11 15:45:28 UTC

Change 100792 had a related patch set uploaded by Esanders:
Allow tables to contain captions!

https://gerrit.wikimedia.org/r/100792

Comment 5 Gerrit Notification Bot 2013-12-11 18:21:19 UTC

Change 100792 merged by jenkins-bot:
Allow tables to contain captions!

https://gerrit.wikimedia.org/r/100792

Comment 6 Gerrit Notification Bot 2013-12-11 22:06:51 UTC

Change 100916 had a related patch set uploaded by Jforrester:
Allow tables to contain captions!

https://gerrit.wikimedia.org/r/100916

Comment 7 Gerrit Notification Bot 2013-12-11 23:13:45 UTC

Change 100916 merged by jenkins-bot:
Allow tables to contain captions!

https://gerrit.wikimedia.org/r/100916

Comment 8 James Forrester 2013-12-12 00:34:32 UTC

Pushed to wmf6.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links