Last modified: 2014-04-28 02:29:15 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T60019, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 58019 - Flow: no-JavaScript glitches (tracking)
Flow: no-JavaScript glitches (tracking)
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
master
All All
: Normal minor with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
: tracking
Depends on: 57895
Blocks: tracking
  Show dependency treegraph
 
Reported: 2013-12-05 05:15 UTC by spage
Modified: 2014-04-28 02:29 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description spage 2013-12-05 05:15:21 UTC
I accidentally left JavaScript disabled, and Flow worked pretty well!

A few things I noticed:

* Topic title and post textareas don't have the blue bar for input focus, they have the blue glow from the older "system" Agora.
I think the fix for this may be simply, in includes/View.php, remove 'mediawiki.ui' from
    $this->output->addModuleStyles( array( 'mediawiki.ui', 'ext.flow.base' ) );
'ext.flow.base' already depends on mediawiki.ui, and for some reason listing it explicitly here makes the CSS in core 'mediawiki.ui' override the ones in 'ext.flow.base'.

* You can create a new topic with no title, server should probably reject that to match the JS behavior
* Clicking underneath a topics' "Comment on <title>" textarea (on the [Reply] button, or to its left) makes the textarea jump bigger. It's disconcerting.
* It's awesome that the moment you click inside a  "Comment on <title>" textarea that it jumps bigger and stays that way.  But the "Reply to <person>" textareas are full-size all the time.
* The [- Hide post] button on my own posts overlaps the post itself. If I login with Admin rights, the [ Delete xx] buttons overlap the post and the topic bar. Maybe these buttons could appear in the right-hand margin, pushing out any vertical space they need.
* A gray text-only ("quiet") button fades in under posts, but its target is '#' so clicking it does nothing.
* No [Preview] button (I think this was already filed.)
* Editing a post takes you to that post in isolation where you can edit it, but there's no indication of what topic it was in. This is Mingle card 378. The decision was to always show the post in context within a topic, but I understand that's difficult to do in no-JavaScript.
* Likewise editing a title takes you to the title in isolation, e.g.
http://ee-flow.wmflabs.org/w/index.php?title=User_talk:Spage&workflow=050afe449da3f00fc8b1fa163e68c4ac&action=edit-title
Comment 1 Bingle 2013-12-05 05:18:33 UTC
The WMF core features team tracks this bug on Mingle card https://mingle.corp.wikimedia.org/projects/flow/cards/589, but people from the community are welcome to contribute here and in Gerrit.
Comment 2 Quiddity 2013-12-19 06:28:40 UTC
more no-javascript notes in the comments from user:64.40.54.139 at https://www.mediawiki.org/w/index.php?title=Talk:Sandbox&workflow=050b96fe92694eea24cf90b11c278164 particularly:

*Needs overflow scrollbars for the textarea (both vert & horiz)

(Re: No [Preview] or [Cancel] buttons - see bug 57895 )
Comment 3 Gerrit Notification Bot 2013-12-26 18:03:24 UTC
Change 103763 had a related patch set uploaded by EBernhardson:
No-js css tweaks

https://gerrit.wikimedia.org/r/103763
Comment 4 Gerrit Notification Bot 2013-12-31 19:15:51 UTC
Change 103763 merged by jenkins-bot:
No-js css tweaks

https://gerrit.wikimedia.org/r/103763
Comment 5 Gerrit Notification Bot 2014-01-30 19:15:40 UTC
Change 110421 had a related patch set uploaded by EBernhardson:
No-js tweaks

https://gerrit.wikimedia.org/r/110421
Comment 6 Gerrit Notification Bot 2014-02-05 23:54:45 UTC
Change 110421 merged by jenkins-bot:
No-js tweaks

https://gerrit.wikimedia.org/r/110421
Comment 7 Kunal Mehta (Legoktm) 2014-02-09 23:43:07 UTC
Lets turn this into a real tracking bug.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links