Last modified: 2006-05-05 12:45:26 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T7791, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 5791 - Wrong sql query syntax on SpecialBrokenRedirects.php
Wrong sql query syntax on SpecialBrokenRedirects.php
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
1.7.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-05-02 13:44 UTC by Ivan Lanin
Modified: 2006-05-05 12:45 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
SpecialBrokenRedirects patch (682 bytes, patch)
2006-05-02 13:44 UTC, Ivan Lanin
Details

Description Ivan Lanin 2006-05-02 13:44:07 UTC
I was using the Special:BrokenRedirects on my internal wiki installation when I
realize that I have too many broken redirects. I found out that the sql syntax
for join is wrong.

Current:
LEFT JOIN $page AS p2 ON (pl_namespace=p2.page_namespace AND
pl_title=p2.page_title AND p2.page_namespace IS NULL)

Should be:
LEFT JOIN $page AS p2 ON (pl_namespace=p2.page_namespace AND pl_title=p2.page_title)
WHERE p2.page_namespace IS NULL

The p2.page_namespace should be used as WHERE, not ON. I've test it in my local
installation and it shows the correct broken redirects.
Comment 1 Ivan Lanin 2006-05-02 13:44:36 UTC
Created attachment 1642 [details]
SpecialBrokenRedirects patch
Comment 2 Rob Church 2006-05-05 12:45:26 UTC
Applied to SVN trunk, r14094.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links