Last modified: 2013-12-17 09:42:35 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T59776, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 57776 - jquery.tablesorter.test.js broken for $wgLanguageCode != en
jquery.tablesorter.test.js broken for $wgLanguageCode != en
Status: NEW
Product: MediaWiki
Classification: Unclassified
Unit tests (Other open bugs)
1.23.0
All All
: Low normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: 31601
  Show dependency tree / graph
 
Reported: 2013-11-30 17:57 UTC by Umherirrender
Modified: 2013-12-17 09:42 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Umherirrender 2013-11-30 17:57:23 UTC 
jquery.tablesorter.test.js is using the mediawiki.language.months module, but that is always loaded in the content language

That means some tests (for complex date parsing) gets broken, when $wgLanguageCode is not 'en'.
Comment 1 Bartosz Dziewoński 2013-11-30 18:08:33 UTC 
Same thing as bug 34093?
Comment 2 Umherirrender 2013-11-30 22:47:56 UTC 
No, that bug is about the transform tables, this bug is about the month names.

The test contains wgMonthNames, but since Gerrit change #55496 the module mediawiki.language.months is used for building the regex instead of the config var, that means the test needs also adjust, because the regex cannot match against the given test data.
But I have no idea to force the load of a module in a other language inside of a QUnit test.
Comment 3 Bartosz Dziewoński 2013-12-01 13:59:24 UTC 
Ughhh. I'm afraid you can't do that.

I'd just overwrite the values in mw.language.months.* from the test runner to English ones (or fix the tests not to depend on that).

(Disclaimer: haven't looked at the code.)
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links