Last modified: 2014-02-12 20:47:45 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T59482, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 57482 - Blocks on user should be checked by ipb_user instead of ipb_address
Blocks on user should be checked by ipb_user instead of ipb_address
Status: NEW
Product: MediaWiki
Classification: Unclassified
User blocking (Other open bugs)
1.23.0
All All
: High major (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-11-23 13:38 UTC by Liangent
Modified: 2014-02-12 20:47 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Liangent 2013-11-23 13:38:01 UTC 
+++ This bug was initially created as a clone of Bug #57481 +++

It seems old Extension:Renameuser didn't update ipb_address correctly, leaving many incorrect ipb_address values in database.

This also affects newly renamed users (due to job queue).

The method of trying to join user table is already used in revision table etc.
Comment 1 Liangent 2013-11-23 13:55:27 UTC 
Brion mentioned in bug 3279 that "the actual block works based on the user ID number" but it seems not the case (anymore?).

Searching for ipb_user in Block.php returns only one usage, in the function to insert new block rows.

Actually there're already reports from users saying that they're accidentially blocked, and the real cause is that they usurped an originally blocked user name in the past, and ipblocks table still stores the user name having been usurped because of (the broken-in-the-past and already-fixed) RenameUser extension.
Comment 2 Liangent 2013-11-23 13:57:22 UTC 
Bumping severity because this causes legitimate users to be (at least practically) blocked.
Comment 3 db [inactive,noenotif] 2013-11-23 20:55:33 UTC 
Sounds like bug 23135
Comment 4 Liangent 2013-11-25 12:20:40 UTC 
(In reply to comment #3)
> Sounds like bug 23135

Not really. This bug says "MediaWiki shouldn't be trapped by data messed up by Extension:Renameuser due to bug 23135".
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links