Last modified: 2014-02-02 21:29:28 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T59297, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 57297 - Add JS component in Core for fullscreen handling
Add JS component in Core for fullscreen handling
Status: PATCH_TO_REVIEW
Product: MediaWiki
Classification: Unclassified
JavaScript (Other open bugs)
1.23.0
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: easy
Depends on:
Blocks: 56477
  Show dependency treegraph
 
Reported: 2013-11-20 11:30 UTC by Tisza Gergő
Modified: 2014-02-02 21:29 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Tisza Gergő 2013-11-20 11:30:29 UTC
MediaViewer has some fullscreen-handling code which would have a better place in core. Something very simple, just to abstract away browser prefixes - something like $.fullscreen.isSupported() /  $.fullscreen.isActive() / $.fullscreen.request() / $.fullscreen.cancel() / $.fullscreen.toggle(), plus triggering the fullscreenchange event if the browser does not support it, plus maybe adding a top-level class.

Docs: https://developer.mozilla.org/en-US/docs/Web/Guide/API/DOM/Using_full_screen_mode
Comment 2 Andre Klapper 2013-11-25 16:51:47 UTC
Tisza: Wondering if this might be a good candidate for Google Code-in, or if this is too complex? See https://www.mediawiki.org/wiki/Google_Code-In
Comment 3 Tisza Gergő 2013-11-25 17:08:53 UTC
It would be a good candidate. The task itself is very simple, (a few dozen lines of javascript which can be pretty much copy-pasted from the above MDN link), you just have to find your way around ResourceLoader (and gerrit etc).
Comment 4 Gerrit Notification Bot 2014-02-02 21:29:25 UTC
Change 110883 had a related patch set uploaded by AalekhN:
jquery.fullscreen.js: Includes toggle handler in jquery.fullscreen

https://gerrit.wikimedia.org/r/110883

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links