Last modified: 2006-04-26 20:42:37 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T7725, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 5725 - maintenance/updaters.inc attempts incorrect mysql conection.
maintenance/updaters.inc attempts incorrect mysql conection.
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Installer (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-04-26 14:21 UTC by Mark Clements (HappyDog)
Modified: 2006-04-26 20:42 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Mark Clements (HappyDog) 2006-04-26 14:21:46 UTC
(This note was posted on mediawiki.org - Don't know if it's a valid bug or not,
I'm adding here so it doesn't get lost --HappyDog).

The bugsystem wont send me an email for a new account and I don't care enough to
follow through via email, so here's a bug report--take it or leave it.

In maintenance/updaters.inc in the function do_interwiki_update(). The
$wgDatabase variable is brought into scope but not passed to the dbsource()
command resulting in PHP attempting to create a new MySQL connection using the
php.ini defaults. This can be fixed by adding the $wgDatabase variable as the
second parameter to the two dbsource() calls in that function.

--169.229.139.92 19:43, 27 February 2006 (UTC)
Comment 1 Antoine "hashar" Musso (WMF) 2006-04-26 19:48:09 UTC
User need to create an Adminsettings.php . It contains the database
user and password for maintenance script, a sample is given and named
Adminsettings.sample .

I added a little comment in update.php (trunk@13876).

Closing as WORKFORME
Comment 2 Rob Church 2006-04-26 20:15:01 UTC
In response to the original issue; the $wgDatabase global is used within the
dbsource() function if a specific database isn't passed to it. Within the
installation and update scopes, this is fine.

In response to the effective problem, I'm going to add a basic check to the
maintenance script to ensure that a connection has been established before
bothering to attempt to update. Reopening until this is done.
Comment 3 Rob Church 2006-04-26 20:42:37 UTC
Now done in SVN trunk, r13880. Will backport to 1.6.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links