Last modified: 2014-09-08 18:44:36 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T59189, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 57189 - Rename key "Credit" to "FileSource"
Rename key "Credit" to "FileSource"
Status: PATCH_TO_REVIEW
Product: MediaWiki extensions
Classification: Unclassified
CommonsMetadata (Other open bugs)
unspecified
All All
: Low normal (vote)
: ---
Assigned To: Amrutha S
https://commons.wikimedia.org/w/api.p...
:
Depends on:
Blocks: 69914
  Show dependency treegraph
 
Reported: 2013-11-18 15:06 UTC by Raimond Spekking
Modified: 2014-09-08 18:44 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Raimond Spekking 2013-11-18 15:06:25 UTC
The information template field "source" is currently matched to "Credit". I think this is wrong or at least misleading. 

The content is often a simple "{{own}}" or a URL.

I suggest to rename the key to "FileSource".
Comment 1 Tisza Gergő 2013-11-19 16:38:11 UTC
Keys for the fields parsed from the description try to match the keys from the file metadata, in this case the Credit field from XMP [1], which "Identifies the provider of the objectdata, not necessarily the owner/creator". In the end, I don't think the naming matters a lot - eventually all such metadata should end up in Wikidata, and the community can decide what property name is best. Until then, only tools will see the field names anyway (we should have better documentation for them, though).


[1] http://www.iptc.org/std/IIM/4.1/specification/IPTC-IIM-Schema4XMP-1.0-spec_1.pdf#page=17
Comment 2 Amrutha S 2014-01-14 13:45:26 UTC
I would like to work on this bug.Can someone please assign this to me.
Comment 3 Tony Thomas 2014-01-14 13:47:12 UTC
Just Prepare your patch
www.mediawiki.org/wiki/Gerrit/Tutorial
Comment 4 Gerrit Notification Bot 2014-01-14 14:19:28 UTC
Change 107368 had a related patch set uploaded by Amruthasangeeth:
Renamed 'Credit' to 'FileSource'

https://gerrit.wikimedia.org/r/107368
Comment 5 Ryan Kaldari 2014-09-05 18:04:10 UTC
While I appreciate the idea of adhering to standards, it doesn't make any sense for us to try to follow XMP (which is designed for very different use cases and not adequate for our needs). It would be much less confusing for everyone if we just followed our own template parameter names.
Comment 6 Tisza Gergő 2014-09-08 10:20:55 UTC
The reason for using the XMP naming schema is that the data extracted from the templates is merged with the XMP data from the file. That way, if the file page does not have an {{Information}} template but the file has a Credit EXIF field, it can be displayed as the author.

In hindsight, that was not a good way of doing things - the XMP vocabulary is not so great and translating it to the names used by [[commons:COM:MRD]] would have been better.

The extmetadata API might soon be superseded by the structured data API though (I am hoping to put up an RFC about that this week); I am not sure it is worth breaking BC on an API that is going to be deprecated any minute.
Comment 7 Tisza Gergő 2014-09-08 10:24:40 UTC
(In reply to Tisza Gergő from comment #6)
> That way, if the file page does not have an {{Information}} template but the 
> file has a Credit EXIF field, it can be displayed as the author.

(Artist, not Credit. Confusing indeed.)
Comment 8 Ryan Kaldari 2014-09-08 17:35:05 UTC
>I am not sure it is worth breaking BC on an API that is going to be deprecated any minute.

I would normally be inclined to agree with you, but I would be surprised if the Wikidata API was available in less than a year.
Comment 9 Tisza Gergő 2014-09-08 18:44:36 UTC
We intend to create a high-level API on top of the low-level data storage mechanism (which might be templates or Wikibase properties, depending on whether the file has been migrated yet); this API won't require Wikibase to be even installed. In it's first iteration, it will be just the current template parsing logic plus a sane output format (non-flat, better field names, none of the value/source/hidden stuff). I think it should be up in a month or two.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links