Last modified: 2014-04-01 13:07:17 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T59094, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 57094 - An element for adding or editing links is added as a list item that looks like an interlanguage link
An element for adding or editing links is added as a list item that looks lik...
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataClient (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Wikidata bugs
u=dev c=frontend p=5
: need-volunteer
: 57367 58102 (view as bug list)
Depends on: 56819
Blocks:
  Show dependency treegraph
 
Reported: 2013-11-15 02:30 UTC by Amir E. Aharoni
Modified: 2014-04-01 13:07 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Amir E. Aharoni 2013-11-15 02:30:11 UTC
Wikibase client adds an "Add links" or "Edit links" as a list item that pretends to be an interlanguage link itself, even though it isn't.

Beyond being semantically incorrect, this causes several real issues, among them:

1. Bug 56819 - The bug title is "Do not apply autonym font to non-language links on interlanguage list", but it would be better not to create non-language links in the first place.

2. Adding a superfluous empty item to pages without interlanguage links in the mobile view, similarly to Bug 57091. For a demo of this issue go to http://en.m.wikipedia.beta.wmflabs.org/wiki/No_language_links and click the "Read in another language" button.
Comment 1 Andre Klapper 2013-11-15 11:00:07 UTC
(In reply to comment #0)
> Wikibase client adds an "Add links" or "Edit links" as a list item that
> pretends to be an interlanguage link itself, even though it isn't.

Could you elaborate what you mean by "it pretends", as it's a different HTML class, and visually it's differently text-align'ed and has a small symbol in front of it?
Comment 2 Amir E. Aharoni 2013-11-15 13:25:11 UTC
(In reply to comment #1)
> Could you elaborate what you mean by "it pretends", as it's a different HTML
> class, and visually it's differently text-align'ed and has a small symbol in
> front of it?

It's different visually, but it's an <li> element in the same <ul> list. It does have a different class, but it's still semantically incorrect, because it's not really a member of the list.

The actual links don't have a common class either, but different classes by language. It's not really great, but it probably shouldn't be changed lightly, because it was used like this for very long. I kinda addressed this in https://gerrit.wikimedia.org/r/#/c/94899/ , but it doesn't really solve the problem, because the interlanguage class will probably be added to the extra Wikidata item, too. (I couldn't actually test it, because I couldn't yet get my Wikidata installation to display links. Configuring Wikibase is surprisingly tricky.)
Comment 3 Amir E. Aharoni 2013-11-21 19:23:30 UTC
*** Bug 57367 has been marked as a duplicate of this bug. ***
Comment 4 Jon 2013-11-21 19:29:55 UTC
Note this causes mobile to render a languages section on pages which have no alternate language versions.
Comment 5 Jon 2013-11-26 16:36:46 UTC
I see this has been backlogged. Please note that mobile have had to hack around this bug in the meantime but the solution to do that is very very nasty and should be removed asap. From our perspective this is a quite important bug for us to get fixed as a slight change in Wikibase's code could lead to confusing behaviour with regards to languages for users.
Comment 6 Lydia Pintscher 2013-11-26 16:45:00 UTC
I understand. That's why it is in the backlog now. (As opposed to pre-backlog.)
Comment 7 Jon 2013-11-26 17:28:14 UTC
Ah ok great! It's just in mobile 'backlog' tends to mean the place where cards go to and don't get worked on forever/a long time :)
Comment 8 Ryan Kaldari 2013-12-06 19:28:58 UTC
*** Bug 58102 has been marked as a duplicate of this bug. ***
Comment 9 Jon 2013-12-06 19:29:23 UTC
This is now effecting mobile users on all wikipedias who are told that a page is available in 1 other language which is not a language.

See bug 57094 for details.
Comment 10 Aude 2013-12-06 19:32:50 UTC
probably we need something like SkinTemplateToolboxEnd for languages, but for putting stuff after the <ul>

any suggestions on how best to do that would be welcome
Comment 11 Gerrit Notification Bot 2013-12-06 20:40:36 UTC
Change 99693 had a related patch set uploaded by Jdlrobson:
Override language_urls template data to avoid hook abuse

https://gerrit.wikimedia.org/r/99693
Comment 12 Andre Klapper 2013-12-06 23:48:17 UTC
*** Bug 58102 has been marked as a duplicate of this bug. ***
Comment 13 Gerrit Notification Bot 2013-12-07 00:31:24 UTC
Change 99693 merged by jenkins-bot:
Override language_urls template data to avoid hook abuse

https://gerrit.wikimedia.org/r/99693
Comment 14 Lydia Pintscher 2013-12-11 10:39:45 UTC
Setting this back to assigned to get the real fix done in Wikibase.
Comment 15 Gerrit Notification Bot 2013-12-16 17:32:00 UTC
Change 101895 had a related patch set uploaded by Aude:
Add SkinTemplateAfterLanguages hook to add html after language links

https://gerrit.wikimedia.org/r/101895
Comment 16 Gerrit Notification Bot 2014-03-12 16:59:23 UTC
Change 101895 merged by Jdlrobson:
Add BaseTemplateAfterPortlet hook to add html after portlets

https://gerrit.wikimedia.org/r/101895
Comment 17 Gerrit Notification Bot 2014-03-12 17:19:52 UTC
Change 118292 had a related patch set uploaded by Aude:
Use BaseTemplateAfterPortlet hook to add "edit / add links" link

https://gerrit.wikimedia.org/r/118292
Comment 18 Gerrit Notification Bot 2014-03-24 15:01:24 UTC
Change 118292 merged by jenkins-bot:
Use BaseTemplateAfterPortlet hook to add "edit/add links" link.

https://gerrit.wikimedia.org/r/118292

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links