Last modified: 2013-11-30 17:56:23 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T59065, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 57065 - E:OpenID does not accept the temporary password when attaching an OpenID to an existing account.
E:OpenID does not accept the temporary password when attaching an OpenID to a...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
OpenID (Other open bugs)
master
All All
: High major (vote)
: ---
Assigned To: T. Gries
:
Depends on:
Blocks: 9604
  Show dependency treegraph
 
Reported: 2013-11-14 18:20 UTC by T. Gries
Modified: 2013-11-30 17:56 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description T. Gries 2013-11-14 18:20:03 UTC
Szenario:

- existing wiki "User" account with a confirmed e-mail address. 
  This account was created earlier via createaccount or createaccount-by-mail,
  a standard mediawiki account ;
- User wants to attach their XYZ-OpenID to their account because there is no OpenID yet ; and
- User has forgotten the password for the wiki User account

User can send a temporary password via Special:PasswordReset to their (previously confirmed) e-mail address.

A password is mandatory when you want to attach an OpenID to an existing account.

Bug:

Current OpenID version do not accept the _temporary_ password when attaching an OpenID to an existing account.

Patch ready.
Comment 1 Gerrit Notification Bot 2013-11-14 18:25:39 UTC
Change 95461 had a related patch set (by Wikinaut) published:
Bug 57065: E:OpenID does not accept temporary password when attaching an OpenID to an existing account

https://gerrit.wikimedia.org/r/95461
Comment 2 Chris Steipp 2013-11-22 03:46:01 UTC
I believe the issue with the change password form showing twice is that the first time, the user is partially logged in with their temporary password, and the ChangePassword form writes out the user's edit token into the token hidden field. When the user submits the form (the first time), they are completely logged out, and the edit token on the form doesn't match the anonymous edit token ('+\'). The second time the form is displayed, the anonymous edit token is written into the token field, and the ChangePassword form submission is correctly processed.
Comment 3 T. Gries 2013-11-22 06:50:27 UTC
(In reply to comment #2)
> I believe the issue with the change password form showing twice is that the
> first time, the user is partially logged in with their temporary password,
> and
> the ChangePassword form writes out the user's edit token into the token
> hidden
> field. When the user submits the form (the first time), they are completely
> logged out, and the edit token on the form doesn't match the anonymous edit
> token ('+\'). The second time the form is displayed, the anonymous edit token
> is written into the token field, and the ChangePassword form submission is
> correctly processed.

Chris,

arguendo you are right with your view,

- why is that then working (usually, showing the page only once) in *normal* MediaWiki context, on - let's say - English Wikipedia, when you come as anon and log-in with your temp.password ?

But perhaps(????) it is related to what I found in https://bugzilla.wikimedia.org/show_bug.cgi?id=57289
Comment 4 T. Gries 2013-11-22 20:48:23 UTC
solved in verion 4.00 20131122
https://gerrit.wikimedia.org/r/#/c/94977/

currently, the password change page appears twice. This will be tracked in a new bug.
Comment 5 Gerrit Notification Bot 2013-11-30 17:56:23 UTC
Change 95461 abandoned by Wikinaut:
Bug 57065: does not accept temporary password when attaching OpenID to existing account

Reason:
thsi patch is not needed

https://gerrit.wikimedia.org/r/95461

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links