Last modified: 2013-11-20 03:45:59 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T58969, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 56969 - File page should use HiDPI src-set for nominal-size rendering
File page should use HiDPI src-set for nominal-size rendering
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
1.21.x
All All
: High minor (vote)
: 1.23.0 release
Assigned To: Nobody - You can work on this!
https://google-melange.appspot.com/gc...
gci2013
: easy
Depends on:
Blocks: hidpi
  Show dependency tree / graph
 
Reported: 2013-11-12 22:30 UTC by Krinkle
Modified: 2013-11-20 03:45 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Krinkle 2013-11-12 22:30:54 UTC 
The image rendering on the File page doesn't use a HiDPI srcset, causing it to look rather pixelated on HiDPI displayed, especially when coming from a page where a thumbnail is shown of the image.

And thumbnails do use a HiDPI srcset, and I bet a significant amount of traffic to file pages comes from clicks on thumbnails.
Comment 1 Bartosz Dziewoński 2013-11-15 21:40:21 UTC 
Looks easy to do.
Comment 2 Thomas Lam 2013-11-18 22:38:15 UTC 
I'm a GCI student that just claimed this task today.  I was trying to get started but couldn't find where I'm supposed to change the file page.  Also is the code that I'm told to reuse the methods in the Linker class for responsive images?
Comment 3 Gerrit Notification Bot 2013-11-19 03:32:59 UTC 
Change 96196 had a related patch set uploaded by Brian Wolff:
Updated File page to use HiPI

https://gerrit.wikimedia.org/r/96196
Comment 4 Bawolff (Brian Wolff) 2013-11-19 03:36:46 UTC 
(In reply to comment #3)
> Change 96196 had a related patch set uploaded by Brian Wolff:
> Updated File page to use HiPI
> 
> https://gerrit.wikimedia.org/r/96196

Just to clarify there, I have nothing to do with this patchset (I added a single newline to the commit message), gerrit bot apparently just likes to use commiter name instead of author :(.
Comment 5 Gerrit Notification Bot 2013-11-19 06:50:43 UTC 
Change 96196 abandoned by Tholam:
Updated File page to use HiPI

https://gerrit.wikimedia.org/r/96196
Comment 6 Gerrit Notification Bot 2013-11-19 06:58:23 UTC 
Change 96212 had a related patch set uploaded by Tholam:
Updated ImagePage to use HiPI

https://gerrit.wikimedia.org/r/96212
Comment 7 Gerrit Notification Bot 2013-11-20 02:18:29 UTC 
Change 96414 had a related patch set uploaded by Tholam:
Updated ImagePage to use HiDPI (GCI Student)

https://gerrit.wikimedia.org/r/96414
Comment 8 Gerrit Notification Bot 2013-11-20 02:19:08 UTC 
Change 96212 abandoned by Tholam:
Updated ImagePage to use HiPI

https://gerrit.wikimedia.org/r/96212
Comment 9 Gerrit Notification Bot 2013-11-20 02:43:18 UTC 
Change 96414 abandoned by Tholam:
Updated ImagePage to use HiDPI (GCI Student)

https://gerrit.wikimedia.org/r/96414
Comment 10 Gerrit Notification Bot 2013-11-20 02:50:06 UTC 
Change 96416 had a related patch set uploaded by Tholam:
Updated ImagePage to use HiDPI

https://gerrit.wikimedia.org/r/96416
Comment 11 Gerrit Notification Bot 2013-11-20 03:36:26 UTC 
Change 96416 merged by jenkins-bot:
Update ImagePage to use HiDPI

https://gerrit.wikimedia.org/r/96416
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links