Last modified: 2013-11-12 09:04:28 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T58080, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 56080 - Language::convertDoubleWidth() doesn't do all it claims (in its name)
Language::convertDoubleWidth() doesn't do all it claims (in its name)
Status: NEW
Product: MediaWiki
Classification: Unclassified
Internationalization (Other open bugs)
unspecified
All All
: Low normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: code_quality
  Show dependency treegraph
 
Reported: 2013-10-24 07:49 UTC by Liangent
Modified: 2013-11-12 09:04 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Liangent 2013-10-24 07:49:48 UTC
It doesn't convert full width punctuations.

On the other hand, I see its only usage is normalization for searches, and what it does now is simply a subset of UtfNormal::toNFKC(). I wonder whether it's possible to drop this function, and just use UtfNormal::toNFKC() (or is it too aggressive or too slow?).
Comment 1 Siebrand Mazeland 2013-10-24 09:49:37 UTC
Hit and run comment: Did you "git blame" to see why it was introduced?
Comment 2 Siebrand Mazeland 2013-10-24 10:00:09 UTC
(In reply to comment #1)
> Hit and run comment: Did you "git blame" to see why it was introduced?

* https://www.mediawiki.org/wiki/Special:Code/MediaWiki/60743
* http://git.wikimedia.org/commit/mediawiki%2Fcore.git/8bbfbf562874f50faa24ef523c3a507b30584dfc

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links