Last modified: 2013-10-15 22:54:14 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
First Last Prev Next    This bug is not in your last search results.
Bug 55722 - Profiling under Postgres is broken
Profiling under Postgres is broken
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Database (Other open bugs)
1.22.0
All All
: Normal minor (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: postgres
  Show dependency tree / graph
 
Reported: 2013-10-15 02:14 UTC by Jeff Janes
Modified: 2013-10-15 22:54 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
proposed patch (2.47 KB, patch)
2013-10-15 02:14 UTC, Jeff Janes 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Jeff Janes 2013-10-15 02:14:22 UTC 
Created attachment 13484 [details]
proposed patch

In maintenance/postgres/tables.sql, the profiling table should be defined like this:

CREATE TABLE profiling (
  pf_count   INTEGER         NOT NULL DEFAULT 0,
  pf_time    FLOAT           NOT NULL DEFAULT 0,
  pf_memory  FLOAT           NOT NULL DEFAULT 0,
  pf_name    TEXT            NOT NULL,
  pf_server  TEXT            NULL
);

The current use of NUMERIC(18,10) very rapidly overflows the pf_memory column, generating errors.  Also, the NUMERIC is very much slower than float, and in this case it has no advantages.

Proposed patch attached.
Comment 1 Gerrit Notification Bot 2013-10-15 20:19:14 UTC 
Change 89995 had a related patch set uploaded by Gerrit Patch Uploader:
In maintenance/postgres/tables.sql, the profiling table should be defined like this:

https://gerrit.wikimedia.org/r/89995
Comment 2 Gerrit Notification Bot 2013-10-15 22:16:50 UTC 
Change 89995 merged by jenkins-bot:
In maintenance/postgres/tables.sql, the profiling table should be defined like this:

https://gerrit.wikimedia.org/r/89995
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links