Last modified: 2013-11-01 17:24:12 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T57477, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 55477 - MultimediaViewer should support hi-DPI ('Retina') displays
MultimediaViewer should support hi-DPI ('Retina') displays
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
MultimediaViewer (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: hidpi
  Show dependency treegraph
 
Reported: 2013-10-08 18:43 UTC by Brion Vibber
Modified: 2013-11-01 17:24 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Brion Vibber 2013-10-08 18:43:45 UTC
(Jotting down some issues noted while testing, things that aren't directly related to the commits.)

Currently the viewer doesn't have any handling for high-DPI/Retina displays -- the image loaded will be sized for 1x density only, and may appear blurry on sharper displays.

Simplest way to handle this in near future would be something like:

* get the display density with $.devicePixelRatio() -- this will return a number like 1, 1.5, 2, or another number depending on the display density and/or browser zoom level. (This is a polyfill for the window.devicePixelRatio property which adds support for IE; don't forget to include the 'jquery.hidpi' module in your dependencies if using it.)

* multiply the target width and height by that ratio and round off to ints; pass that pixel size into the imageinfo request when asking for a thumbnail.

* don't forget to use the _non-multiplied_ sizes in width/height attributes on the <img>
Comment 1 Gerrit Notification Bot 2013-11-01 15:25:17 UTC
Change 93068 had a related patch set uploaded by Brion VIBBER:
Bug 55477: MultimediaViewer hi-DPI support

https://gerrit.wikimedia.org/r/93068
Comment 2 Gerrit Notification Bot 2013-11-01 16:20:06 UTC
Change 93068 had a related patch set uploaded by MarkTraceur:
Bug 55477: MultimediaViewer hi-DPI support

https://gerrit.wikimedia.org/r/93068
Comment 3 Gerrit Notification Bot 2013-11-01 17:23:57 UTC
Change 93068 merged by jenkins-bot:
MultimediaViewer hi-DPI support

https://gerrit.wikimedia.org/r/93068

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links