Last modified: 2014-03-25 22:57:48 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T57421, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 55421 - CodeEditor should not override skin font styles for input areas
CodeEditor should not override skin font styles for input areas
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
CodeEditor (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on: 54136
Blocks:
  Show dependency tree / graph
 
Reported: 2013-10-07 16:54 UTC by Isarra
Modified: 2014-03-25 22:57 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Isarra 2013-10-07 16:54:29 UTC 
For some reason it's overriding the normal fonts with hardcoded inline styles.

This not only makes it inconsistent with the rest of the skin, but the specific fonts chosen can also be rather poor choices depending on the OS, browser, and potentially any disabilities of the user. CodeEditor should inherit the skin code fonts so that these issues can all be avoided/resolved consistently.
Comment 1 Brion Vibber 2013-10-07 17:01:47 UTC 
Note that currently the editor requires a monospace font to function, this would need fixing to allow defaults through. bug 54136
Comment 2 Isarra 2013-10-07 17:10:21 UTC 
Well, editing/showing code without a monospace font is usually pretty silly, so skins can generally be trusted to use a monospace, just not always the same ones. That it can vary is part of why this should inherit it, whatever it is.

(And if they can't see the value of using monospace for that, perhaps they deserve this to explode in their faces?)
Comment 3 Isarra 2013-10-07 17:12:41 UTC 
Also legibility. I can't read the defaults on top of Bug 55423, frankly. Bloody tiny.
Comment 4 Derk-Jan Hartman 2014-03-25 22:57:48 UTC 
Currently ACE has its own styling and specifies:

.ace_editor {
font-family: 'Monaco', 'Menlo', 'Ubuntu Mono', 'Consolas', 'source-code-pro', monospace;
}
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links