Last modified: 2014-03-10 22:00:40 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 54724 - Cleanup upload code
Cleanup upload code
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
PronunciationRecording (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Rahul Maliakkal
:
Depends on:
Blocks: code_quality
  Show dependency treegraph
 
Reported: 2013-09-27 22:09 UTC by Matthew Flaschen
Modified: 2014-03-10 22:00 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Matthew Flaschen 2013-09-27 22:09:25 UTC
PronunciationRecording currently use UploadWizard's upload code.  However, PronunciationRecording workarounds (and a couple hacks) to deal with the fact that that upload code is not fully modular (it reaches into other parts of UploadWizard).

This should be cleaned up so that the dependencies make sense.  Part of this will have to be on the UploadWizard side (https://gerrit.wikimedia.org/r/#/c/84344/).  

After that, PronunciationRecording will need to be adapted accordingly, fixing this bug.

In the future, it would be good to have the client upload code in core, but that is not in the scope of this bug.
Comment 1 Rainer Rillke @commons.wikimedia 2014-03-08 22:55:03 UTC
(In reply to Matthew Flaschen from comment #0)
> In the future, it would be good to have the client upload code in core, but 
> that is not in the scope of this bug.

I think it's an important matter we should keep track of. Has it a Bugzilla entry?
Comment 2 Matthew Flaschen 2014-03-10 22:00:40 UTC
(In reply to Rainer Rillke @commons.wikimedia from comment #1)
> (In reply to Matthew Flaschen from comment #0)
> > In the future, it would be good to have the client upload code in core, but 
> > that is not in the scope of this bug.
> 
> I think it's an important matter we should keep track of. Has it a Bugzilla
> entry?

Not that I know of.  Just filed as bug 62513.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links