Last modified: 2014-11-14 16:08:14 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T56597, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 54597 - Remove $wgBlockOpenProxies (or move to an extension)
Remove $wgBlockOpenProxies (or move to an extension)
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
User blocking (Other open bugs)
1.22.0
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: 29145
  Show dependency treegraph
 
Reported: 2013-09-25 11:51 UTC by Kevin Israel (PleaseStand)
Modified: 2014-11-14 16:08 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Kevin Israel (PleaseStand) 2013-09-25 11:51:08 UTC
From includes/DefaultSettings.php:

/**
 * If you enable this, every editor's IP address will be scanned for open HTTP
 * proxies.
 *
 * @warning Don't enable this. Many sysops will report "hostile TCP port scans"
 * to your ISP and ask for your server to be shut down.
 * You have been warned.
 */

As a feature that, according to its documentation, most wikis should not enable, and furthermore one that currently requires a deprecated, undocumented setting ($wgProxyKey) to use securely, does it really make sense to keep it in core MediaWiki?
Comment 1 Chris Steipp 2013-09-27 00:26:54 UTC
I think this is a good idea, if anyone is up for doing the work.
Comment 2 Bartosz Dziewoński 2013-09-27 00:27:36 UTC
Can we just remove it? I'm up for removing. :P
Comment 3 Gerrit Notification Bot 2013-10-03 01:06:44 UTC
Change 87302 had a related patch set uploaded by PleaseStand:
Remove $wgBlockOpenProxies

https://gerrit.wikimedia.org/r/87302
Comment 4 Gerrit Notification Bot 2013-10-21 01:17:54 UTC
Change 87302 merged by jenkins-bot:
Remove proxy check in EditPage.php

https://gerrit.wikimedia.org/r/87302
Comment 5 Tyler Romeo 2013-10-21 01:19:05 UTC
Removal plan works.
Comment 6 Nemo 2013-10-21 05:36:51 UTC
How does this relate to bug 8475?
Comment 7 Jasper Deng 2013-10-21 06:01:40 UTC
(In reply to comment #6)
> How does this relate to bug 8475?

It basically would revert that bug to "WONTFIX".
Comment 8 Kevin Israel (PleaseStand) 2013-10-21 07:24:40 UTC
(In reply to comment #7)
> (In reply to comment #6)
> > How does this relate to bug 8475?
> 
> It basically would revert that bug to "WONTFIX".

Not necessarily. That bug was filed against the Wikimedia product, not against MediaWiki core, and it would still be possible to implement such a feature as an extension.
Comment 9 Cenarium 2014-11-14 14:58:16 UTC
Change was not complete. It did not remove the proxyunbannable userright from sysop which granted immunity to $wgBlockOpenProxies.
Comment 10 Cenarium 2014-11-14 15:05:19 UTC
*** Bug 73414 has been marked as a duplicate of this bug. ***
Comment 11 Kevin Israel (PleaseStand) 2014-11-14 16:08:14 UTC
(In reply to Cenarium from comment #9)
> Change was not complete. It did not remove the proxyunbannable userright
> from sysop which granted immunity to $wgBlockOpenProxies.

The user right was not removed because it also applies to local proxy blocking ($wgProxyList) and DNSBL-based proxy blocking ($wgEnableDnsBlacklist). Please enter a separate report if you want those features removed or moved to extensions.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links