Last modified: 2014-07-18 12:51:55 UTC
Today I saw a few time the message place holder <mwe-upwiz-undefined> in the last step of the UploadWizard.
I'm going to guess js error where mw-upwiz- is being concated with an undefined variable
Adding many blockers of bug 38638 to the list of "easy" bugs, to mark them as candidates for [[mw:Google Code-in]] tasks (gci2013). If you think this bug is not suitable, remove the keyword.
(In reply to comment #0) Is this reproducible? or does this happen every time?
(In reply to comment #1) > I'm going to guess js error where mw-upwiz- is being concated with an > undefined > variable Then, unless Raymond finds the place(s) where this happens consistently, this is what it takes to fix this: 1) go through all the places where message keys are constructed and add all possibly resulting keys as code comments, per [[mw:Localisation#Using messages]]; 2) check that they all exist, fix/add them where missing. A bit tedious but easy and needs to be done anyway, can we get a GCI task please? :)
I think line 230 in mw.FormDataTransport and line 1341 in mw.UploadWizardDetails.js are the problems. response.upload.stage is returning undefined in the first one and result.upload.stage is returning undefined in the second one. I cant find any other problems in UW related to this bug
Change 104782 had a related patch set uploaded by Mayankmadan: Adding code comments of resulting keys https://gerrit.wikimedia.org/r/104782
Is there a particular way to call the mw.UploadWizardDetails function?
Change 104782 merged by jenkins-bot: Adding code comments of resulting keys https://gerrit.wikimedia.org/r/104782
All patches were merged a while ago - is there more work left to do here (if yes: please reset the bug report status to NEW or ASSIGNED), or can you close this ticket as RESOLVED FIXED?
No reply to comment 9 - assuming this is fixed by the merged patch.
