Last modified: 2014-07-18 12:51:55 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
First Last Prev Next    This bug is not in your last search results.
Bug 54524 - Missing message <mwe-upwiz-undefined>
Missing message <mwe-upwiz-undefined>
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UploadWizard (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
http://www.google-melange.com/gci/tas...
gci2013
: easy, i18n
Depends on:
Blocks: messages
  Show dependency tree / graph
 
Reported: 2013-09-24 19:55 UTC by Raimond Spekking
Modified: 2014-07-18 12:51 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Raimond Spekking 2013-09-24 19:55:25 UTC 
Today I saw a few time the message place holder <mwe-upwiz-undefined> in the last step of the UploadWizard.
Comment 1 Bawolff (Brian Wolff) 2013-09-24 20:35:58 UTC 
I'm going to guess js error where mw-upwiz- is being concated with an undefined variable
Comment 2 Nemo 2013-11-19 12:36:10 UTC 
Adding many blockers of bug 38638 to the list of "easy" bugs, to mark them as candidates for [[mw:Google Code-in]] tasks (gci2013). If you think this bug is not suitable, remove the keyword.
Comment 3 Nischay Nahata 2013-12-25 17:11:50 UTC 
(In reply to comment #0)
Is this reproducible? or does this happen every time?
Comment 4 Nemo 2013-12-26 10:54:49 UTC 
(In reply to comment #1)
> I'm going to guess js error where mw-upwiz- is being concated with an
> undefined
> variable

Then, unless Raymond finds the place(s) where this happens consistently, this is what it takes to fix this:
1) go through all the places where message keys are constructed and add all possibly resulting keys as code comments, per [[mw:Localisation#Using messages]];
2) check that they all exist, fix/add them where missing.
A bit tedious but easy and needs to be done anyway, can we get a GCI task please? :)
Comment 5 Mayank Madan 2013-12-31 23:41:34 UTC 
I think line 230 in mw.FormDataTransport and line 1341 in mw.UploadWizardDetails.js are the problems. response.upload.stage is returning undefined in the first one and result.upload.stage is returning undefined in the second one. I cant find any other problems in UW related to this bug
Comment 6 Gerrit Notification Bot 2013-12-31 23:55:33 UTC 
Change 104782 had a related patch set uploaded by Mayankmadan:
Adding code comments of resulting keys

https://gerrit.wikimedia.org/r/104782
Comment 7 Mayank Madan 2014-01-01 11:34:57 UTC 
Is there a particular way to call the mw.UploadWizardDetails function?
Comment 8 Gerrit Notification Bot 2014-01-02 20:20:54 UTC 
Change 104782 merged by jenkins-bot:
Adding code comments of resulting keys

https://gerrit.wikimedia.org/r/104782
Comment 9 Andre Klapper 2014-03-13 11:44:57 UTC 
All patches were merged a while ago - is there more work left to do here (if yes: please reset the bug report status to NEW or ASSIGNED), or can you close this ticket as RESOLVED FIXED?
Comment 10 Andre Klapper 2014-07-18 12:51:55 UTC 
No reply to comment 9 - assuming this is fixed by the merged patch.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links