Last modified: 2013-11-22 20:49:30 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T56507, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 54507 - When having a forced provider, disallow adding (converting) further OpenIDs from non-allowed providers: only allow to add the forced provider.
When having a forced provider, disallow adding (converting) further OpenIDs f...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
OpenID (Other open bugs)
master
All All
: Lowest normal (vote)
: ---
Assigned To: T. Gries
:
Depends on:
Blocks: 9604
  Show dependency treegraph
 
Reported: 2013-09-24 16:19 UTC by Brad Jorsch
Modified: 2013-11-22 20:49 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Brad Jorsch 2013-09-24 16:19:17 UTC
I set $wgOpenIDAllowExistingAccountSelection = false, but it still shows the link to Special:OpenIDConvert on Special:Preferences and Special:OpenIDConvert still acts like it will work.
Comment 1 T. Gries 2013-10-06 16:47:59 UTC
(In reply to comment #0)
> I set $wgOpenIDAllowExistingAccountSelection = false, but it still shows the
> link to Special:OpenIDConvert on Special:Preferences and
> Special:OpenIDConvert
> still acts like it will work.

You most probably misunderstood the meaning of this parameter. 

Let me explain.

According to https://www.mediawiki.org/wiki/Openid#Configuration it does this when set "true":

"when first-time logging in with OpenID, show option to select an existing MediaWiki user"

So when you "create an account" on an E:OpenID-enabled wiki, it shows you _also_ a form where you can enter i) the name of an existing account user ii) the associated password. In that way, you can "come" with your OpenID to your MediaWiki, login and associate that OpenID with the user account.

I am closing this bug, but feel free to reopen it, if you are unhappy with my decision and if you need further clarifications.
Comment 2 Brad Jorsch 2013-10-07 14:53:41 UTC
What I was looking for was a situation where you want a 1:1 relationship between local accounts and accounts on the one forced provider. The OpenID extension seemed to support this by only allowing login/account creation via OpenID and by forcing the use of one particular provider, but then there was still the ability to attach other accounts from the provider to the local account.
Comment 3 T. Gries 2013-10-07 17:12:29 UTC
(In reply to comment #2)
> What I was looking for was a situation where you want a 1:1 relationship
> between local accounts and accounts on the one forced provider. The OpenID
> extension seemed to support this by only allowing login/account creation via
> OpenID and by forcing the use of one particular provider, but then there was
> still the ability to attach other accounts from the provider to the local
> account.

okay, now I understand what you want. Good point. I remember this issue, but it went off my screen...
Comment 4 Brad Jorsch 2013-10-07 18:00:03 UTC
What if some site does want to allow tying the local account to more than one account on the forced provider? Or considering the "one or more forced providers" wording, what if some site wants to allow tying the local account to more than one of the available forced providers?

Or, given that the config variable isn't intended to do what I thought it was supposed to do, what if some site does want to allow attaching existing local accounts to the newly-forced provider?
Comment 5 T. Gries 2013-10-07 18:16:05 UTC
Yes, yes, yes, yes, yes. And yes. The "Convert" page should only allow to add OpenID from allowed (may be forced) providers.

You are making it too complicate. I do know, what you really want - pls. be patient, or make a clean commit.
Comment 6 T. Gries 2013-11-22 20:49:30 UTC
solved in 4.00 20131122
https://gerrit.wikimedia.org/r/#/c/94977/

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links