Last modified: 2013-09-23 19:33:52 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 54473 - HtmlFormatter performs weird undocumented transforms
HtmlFormatter performs weird undocumented transforms
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Documentation (Other open bugs)
1.22.0
All All
: Unprioritized normal (vote)
: ---
Assigned To: Max Semenik
:
Depends on:
Blocks: code_quality
  Show dependency treegraph
 
Reported: 2013-09-23 17:22 UTC by Bartosz Dziewoński
Modified: 2013-09-23 19:33 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Bartosz Dziewoński 2013-09-23 17:22:17 UTC
Copying from CR: https://gerrit.wikimedia.org/r/#/c/84342/5

"$html = str_replace( ' <', '&#32;<', $html );" – commented only with a link to bug 53086, apparently ugly workaround for some bug or feature

"if ( wfIsWindows() ) { $html = str_replace( '&#13;', '', $html ); }" – not commented on at all

Supported CSS selectors for remove() are not documented.


elementsToFlatten functionality uses very simple regexes for the transformation; it should be documented that it only works correctly if the elements have no attributes, lest someone use it for HTML sanitization.
Comment 1 Gerrit Notification Bot 2013-09-23 17:44:14 UTC
Change 85687 had a related patch set uploaded by Brion VIBBER:
bug 54473: doc fixes for HtmlFormatter

https://gerrit.wikimedia.org/r/85687
Comment 2 Gerrit Notification Bot 2013-09-23 17:52:33 UTC
Change 85687 had a related patch set uploaded by Krinkle:
bug 54473: doc fixes for HtmlFormatter

https://gerrit.wikimedia.org/r/85687
Comment 3 Gerrit Notification Bot 2013-09-23 17:58:50 UTC
Change 85687 merged by jenkins-bot:
Fix doc for HtmlFormatter

https://gerrit.wikimedia.org/r/85687

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links