Last modified: 2013-09-23 19:33:52 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T56473, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 54473 - HtmlFormatter performs weird undocumented transforms


Summary:	HtmlFormatter performs weird undocumented transforms

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	Documentation (Other open bugs)
Version:	1.22.0
Hardware:	All All

Importance:	Unprioritized normal (vote)
Target Milestone:	---
Assigned To:	Max Semenik

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	code_quality
	Show dependency tree / graph

Reported:	2013-09-23 17:22 UTC by Bartosz Dziewoński
Modified:	2013-09-23 19:33 UTC (History)
CC List:	3 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Bartosz Dziewoński 2013-09-23 17:22:17 UTC

Copying from CR: https://gerrit.wikimedia.org/r/#/c/84342/5

"$html = str_replace( ' <', '&#32;<', $html );" – commented only with a link to bug 53086, apparently ugly workaround for some bug or feature

"if ( wfIsWindows() ) { $html = str_replace( '&#13;', '', $html ); }" – not commented on at all

Supported CSS selectors for remove() are not documented.


elementsToFlatten functionality uses very simple regexes for the transformation; it should be documented that it only works correctly if the elements have no attributes, lest someone use it for HTML sanitization.

Comment 1 Gerrit Notification Bot 2013-09-23 17:44:14 UTC

Change 85687 had a related patch set uploaded by Brion VIBBER:
bug 54473: doc fixes for HtmlFormatter

https://gerrit.wikimedia.org/r/85687

Comment 2 Gerrit Notification Bot 2013-09-23 17:52:33 UTC

Change 85687 had a related patch set uploaded by Krinkle:
bug 54473: doc fixes for HtmlFormatter

https://gerrit.wikimedia.org/r/85687

Comment 3 Gerrit Notification Bot 2013-09-23 17:58:50 UTC

Change 85687 merged by jenkins-bot:
Fix doc for HtmlFormatter

https://gerrit.wikimedia.org/r/85687

Note You need to log in before you can comment on or make changes to this bug.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links