Last modified: 2014-02-19 13:26:08 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T55939, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 53939 - Testing spam blacklist prior to abuse filters
Testing spam blacklist prior to abuse filters
Status: NEW
Product: Wikimedia
Classification: Unclassified
General/Unknown (Other open bugs)
wmf-deployment
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: SWMT
  Show dependency treegraph
 
Reported: 2013-09-09 12:14 UTC by billinghurst
Modified: 2014-02-19 13:26 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description billinghurst 2013-09-09 12:14:32 UTC
At this moment, we are getting spambots that are spamming blacklisted domain names, however, they are hitting the AbuseFilters first.  This means that we are getting a lot of abuse reports to wade through (sloooooow process) only to find that domain is blacklisted and there is no need to further manage the domain.

I am wondering whether it is possible to run the checks against the global spam blacklist prior to running the abuse filter checks.

I understand that this will mean that I may miss seeing that an account is spamming a blacklisted url, however, I can live with that.  Spambots do not tend to offer more than the one spam url.
Comment 1 Kunal Mehta (Legoktm) 2013-09-09 12:21:24 UTC
According to https://www.mediawiki.org/wiki/Manual:Hooks, the order hooks are called depends on when they are loaded.

Looking at CommonSettings.php, first the SpamBlacklist is loaded, then AbuseFilter.

Both AF and SB use the APIEditBeforeSave and EditFilterMergedContent hooks, so I'm not sure why the SpamBlacklist isn't stopping these first.
Comment 2 billinghurst 2013-09-09 12:51:06 UTC
/me shrugs

bit.ly is blacklisted

https://meta.wikimedia.org/wiki/Special:AbuseFilter/examine/log/23182
Comment 3 Andre Klapper 2013-09-09 19:41:46 UTC
(In reply to comment #1)
> Looking at CommonSettings.php, first the SpamBlacklist is loaded, then
> AbuseFilter.

So the question would be whether the order can be switched without bad side effects?
Comment 4 Kunal Mehta (Legoktm) 2013-09-09 19:44:23 UTC
(In reply to comment #3)
> (In reply to comment #1)
> > Looking at CommonSettings.php, first the SpamBlacklist is loaded, then
> > AbuseFilter.
> 
> So the question would be whether the order can be switched without bad side
> effects?

Er, it's already in the correct order I believe. If SB is loaded first, it should register its hook first, which means it should get called first.
Comment 5 billinghurst 2014-02-19 13:24:06 UTC
This is still occurring, twice today.  Here is one

https://meta.wikimedia.org/wiki/Special:AbuseFilter/examine/log/29897

welovesbobet.net is caught by blacklists: [global] \bwelovesbobet\.net\b
Comment 6 billinghurst 2014-02-19 13:26:08 UTC
and not showing (In reply to billinghurst from comment #5)
> This is still occurring, twice today.  Here is one
> 
> https://meta.wikimedia.org/wiki/Special:AbuseFilter/examine/log/29897
> 
> welovesbobet.net is caught by blacklists: [global] \bwelovesbobet\.net\b

and not showing in the spam blacklist log

https://meta.wikimedia.org/w/index.php?title=Special%3ALog&type=spamblacklist&user=&page=&year=&month=-1&tagfilter=&hide_patrol_log=1&hide_review_log=1&hide_thanks_log=1

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links