Last modified: 2014-08-15 14:27:45 UTC
Special:InviteSignup has following table structure: <table> <thead> <tr> <th></th> </tr> <tr> <td></td> </tr> </thead> <tr> <td></td> </tr> </table> Sortable table places the sort arrows on the second tr, where I would expect them to be on the first one. I've identified the cause to be in buildHeaders line 314 of jquery.tablesorter.js: if ( cellArray.length >= maxSeen ) { This makes it choose last longest row, instead of the first one. Changing that to '>' makes it work, but there might be better solutions.
Tablesorter is expecting all elements in the thead to be columnheaders currently.
Does https://gerrit.wikimedia.org/r/#/c/98250/ fix this?
DJ: Will your patch in https://gerrit.wikimedia.org/r/#/c/98250/ fix this?
DJ: Do you know if your patch in https://gerrit.wikimedia.org/r/#/c/98250/ will fix this?
No reply - I assume this was fixed by https://gerrit.wikimedia.org/r/#/c/98250/2/resources/jquery/jquery.tablesorter.js which was merged in March. If not, please reopen.
Not fixed. It seems worse now. The arrows are not visible and all the input elements on the second header row cannot be interacted with.
@Niklas, that <form> inside the row is not really valid HTML5 I think. <form> is supposed to be in http://www.w3.org/TR/html5/dom.html#flow-content-1, and though <table> is flow-content, the <tr> itself only accepts a very limited amount of children: http://www.w3.org/TR/html5/tabular-data.html#the-tr-element We should probably get that fixed. Now looking at the rest of this report..
Change 152225 had a related patch set uploaded by TheDJ: jquery.tablesorter: Only look at th's for headers https://gerrit.wikimedia.org/r/152225
Change 152225 merged by jenkins-bot: jquery.tablesorter: Only look at th's for headers https://gerrit.wikimedia.org/r/152225
