Last modified: 2014-06-03 10:51:26 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T54463, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 52463 - VisualEditor: Media insertion dialog should display a message if no media is found for the given search
VisualEditor: Media insertion dialog should display a message if no media is ...
Status: VERIFIED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: High trivial
: VE-deploy-2014-05-15
Assigned To: Moriel Schottlender
:
: 60932 (view as bug list)
Depends on:
Blocks: ve-mediasupport
  Show dependency treegraph
 
Reported: 2013-08-02 16:26 UTC by Chris McKenna
Modified: 2014-06-03 10:51 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screenshot (115.48 KB, image/png)
2014-05-16 19:27 UTC, Rummana Yasmeen
Details

Description Chris McKenna 2013-08-02 16:26:24 UTC
en.wp user:Wouterstomp asks.
"When no image is found, please display a message saying so, now it looks like nothing is happening (especially [if you] missed the short busy animation of the search bar)"
The context is the image insertion dialog.
Comment 1 WhatamIdoing 2013-08-15 17:41:25 UTC
Given the fact that users often want to add the image that they just uploaded, and that Commons's search is fairly often taking a couple of days to "notice" that these images exist, the default message on wikis that use Commons should say something like "No image was found.  If you just uploaded an image with this name, this may be due to the image not being indexed in Commons's search database yet.  Please try again in a couple of days."

It might also be worth linking to a help page that describes limitations in the search protocol.  For example, it will find images if I give it the whole name ("2013AliceAndBob") but not if I give it just the start of the name ("2013Alice").
Comment 2 James Forrester 2014-02-06 04:00:53 UTC
*** Bug 60932 has been marked as a duplicate of this bug. ***
Comment 3 Jared Zimmerman (WMF) 2014-02-06 18:35:53 UTC
WhatamIdoing, there is a design that has not been implemented yet for the image dialog that allow quick access to users uploads, perhaps in the case of zero search results, we can automatically show that mode.
Comment 4 Gerrit Notification Bot 2014-05-13 06:41:45 UTC
Change 133050 had a related patch set uploaded by Mooeypoo:
If no media is found display a message in media insert dialog

https://gerrit.wikimedia.org/r/133050
Comment 5 Gerrit Notification Bot 2014-05-14 23:10:25 UTC
Change 133050 merged by jenkins-bot:
If no media is found display a message in media insert dialog

https://gerrit.wikimedia.org/r/133050
Comment 6 Rummana Yasmeen 2014-05-16 19:26:40 UTC
The message "No results found" stays in the dialog even if user changed the search string and the matched images appear inside the dialog.See the screenshot attached
Comment 7 Rummana Yasmeen 2014-05-16 19:27:09 UTC
Created attachment 15419 [details]
Screenshot
Comment 8 Gerrit Notification Bot 2014-05-16 22:41:37 UTC
Change 133858 had a related patch set uploaded by Mooeypoo:
Hide 'no results found' once there's at least one result

https://gerrit.wikimedia.org/r/133858
Comment 9 Gerrit Notification Bot 2014-05-16 23:16:21 UTC
Change 133858 merged by jenkins-bot:
Hide 'no results found' once there's at least one result

https://gerrit.wikimedia.org/r/133858
Comment 10 Gerrit Notification Bot 2014-05-16 23:24:01 UTC
Change 133864 had a related patch set uploaded by Jforrester:
Hide 'no results found' once there's at least one result

https://gerrit.wikimedia.org/r/133864
Comment 11 Gerrit Notification Bot 2014-05-19 21:44:29 UTC
Change 133864 merged by jenkins-bot:
Hide 'no results found' once there's at least one result

https://gerrit.wikimedia.org/r/133864
Comment 12 Rummana Yasmeen 2014-05-19 22:06:09 UTC
Verified the fix in Betalabs
Comment 13 Rummana Yasmeen 2014-05-22 21:35:26 UTC
Verified in production

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links