Last modified: 2014-05-28 04:16:45 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T53734, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 51734 - TemplateData: Create an editor for template data (in the wikitext editor)
TemplateData: Create an editor for template data (in the wikitext editor)
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
TemplateData (Other open bugs)
unspecified
All All
: High enhancement with 1 vote (vote)
: ---
Assigned To: Moriel Schottlender
:
Depends on:
Blocks: 50436 60158 td-gui-stable
  Show dependency treegraph
 
Reported: 2013-07-20 08:21 UTC by NicoV
Modified: 2014-05-28 04:16 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
GUI for the existing TemplateDataEditor (44.92 KB, image/png)
2013-07-20 08:21 UTC, NicoV
Details
Screenshot of http://tools.wikimedia.pl/~mlazowik/templatedata/ (236.46 KB, image/png)
2013-07-25 18:07 UTC, Krinkle
Details
TemplateDataGenertor screenshot (83.26 KB, image/png)
2014-01-31 20:01 UTC, Ltrlg
Details

Description NicoV 2013-07-20 08:21:08 UTC
Created attachment 12900 [details]
GUI for the existing TemplateDataEditor

Not the same as bug 50964: it would be really nice to provide a tool for editing TemplateData also outside VisualEditor (I even think it's better than inside VisualEditor because VE doesn't work on Template namespace right now).

The existing TemplateDataEditor script (created by Ltrlg on frwiki, translated for enwiki by me), can be a good start. Benefits for including some equivalent in TemplateData extensions are important :
* Available to all wikis
* Translations can be done like they are done for TemplateData

Links :
* http://en.wikipedia.org/wiki/User:NicoV/TemplateDataEditor
* http://fr.wikipedia.org/wiki/Utilisateur:Ltrlg/scripts/TemplateDataEditor.js
Comment 1 Andre Klapper 2013-07-22 09:56:13 UTC
Could you please define what that "tool" would exactly do? 
Otherwise it will be extremely hard to define when this bug report could be considered "fixed" at some point. :)
Comment 2 Helder 2013-07-22 10:37:23 UTC
Tool = something at least as good as the TemplateDataEditor linked above.
Comment 3 Helder 2013-07-22 10:40:51 UTC
(In reply to comment #0)
...
> editing TemplateData also outside VisualEditor (I even think it's better than
> inside VisualEditor because VE doesn't work on Template namespace right now).

BTW: depending on the resolution of bug 50512, the data might be migrated from Template namespace to a specific one.
Comment 4 NicoV 2013-07-22 12:23:13 UTC
(In reply to comment #1)
> Could you please define what that "tool" would exactly do? 
> Otherwise it will be extremely hard to define when this bug report could be
> considered "fixed" at some point. :)

Being able to edit a <templatedata> tag in a user frienly way, much like what TemplateDataEditor allows (see the attached screenshot in my first comment). JSON is not very friendly for human editors.
Basically, a window showing all the informations in the <templatedata/> and allowing a human editor to modify them easily.

Extra advantage of including this in the TemplateData extension :
* Users don't have to modify their common.js to have access to an editor
Comment 5 James Forrester 2013-07-22 16:20:28 UTC
This is, indeed, not a duplicate of bug 50169, though it might as well be done in one go. Relabelling as such.
Comment 6 Krinkle 2013-07-25 18:07:08 UTC
Created attachment 12957 [details]
Screenshot of http://tools.wikimedia.pl/~mlazowik/templatedata/
Comment 7 Krinkle 2013-07-25 18:17:55 UTC
(In reply to comment #0)
> Created attachment 12900 [details]
> GUI for the existing TemplateDataEditor
> 
> Not the same as bug 50964

Indeed, bug 50964 is not the same, but also (apparently) completely unrelated. I assume you meant bug 50169.

If this should not (also) be inside VisualEditor, can we be specific in what we want it to be then?

e.g. WikiEditor, legacy toolbar, ...

The referenced gadget 'parses' the wikitext textarea and adds a link in the sidebar toolbox that opens a dialog. I don't think the sidebar would be an acceptable entry point to edit the wikitext. Should be something in the toolbar.

I agree we should re-use the data logic between these 2 or 3 different things. At least we can expose the data logic separately from the plugin we make for VisualEditor so that other ones can be created as gadget (until (if) we make one of the WikiEditor and/or legacy toolbar).
Comment 8 NicoV 2013-07-25 18:45:39 UTC
I don't know how I messed up with the bug number (probably several bugzilla windows opened and I paste the wrong one) ;-) Sorry, bug 50169 of course.

I also think having a button in the toolbar would be a better place than the sidebar.


Other possible optimization: combine it with the "Skeleton generator" so that parameter names are automatically retrieved from the template source code for initializing the templatedata the first time. Care must be taken since the templatedata will often be on the documentation page.

http://singsurf.org/things/TemplateData.php?Source=true
Comment 9 Richard Morris 2013-07-29 23:17:29 UTC
Skeleton generator now in javascript and at http://en.wikipedia.org/wiki/User:Salix_alba/TDSkell
its quite handy for getting a complete list of parameters. The human written documentation is not always upto date.
Comment 10 Gerrit Notification Bot 2013-12-11 17:49:07 UTC
Change 85400 had a related patch set uploaded by Jforrester:
TemplateData Generator GUI

https://gerrit.wikimedia.org/r/85400
Comment 11 James Forrester 2014-01-15 17:26:58 UTC
This is done in I863a8199c0b08cc52b320ed00dcba912dd2aeefc (though it's not yet deployed, as it is currently hidden behind a feature flag). Closing for now. If a particular wiki is happy to be a guinea pig we can switch it on there for a little for some real-world testing.
Comment 12 Quim Gil 2014-01-21 20:28:56 UTC
(In reply to comment #11)
> If
> a particular wiki is happy to be a guinea pig we can switch it on there for a
> little for some real-world testing.

Sound interesting, but I'm missing a bit of background...

Do you mean "switch on" https://en.wikipedia.org/wiki/User:Salix_alba/TDSkell ? Would it be enabled to all users of a wiki or can it be restricted to a certain user group in order limit the experiment a bit?

There is clear interest in improving template data coverage in Catalan Wikipedia but, guess what, nobody really enjoys editing JSON syntax.  :)
Comment 13 James Forrester 2014-01-22 23:00:56 UTC
No, this is the GUI we developed hidden behind $wgTemplateDataUseGUI.
Comment 14 stratoprutser 2014-01-27 11:50:33 UTC
Hi, we would like to try the TempalteDataEditor on NL wiki, see https://nl.wikipedia.org/wiki/Wikipedia:De_kroeg#Aanzetten_TemplateData-editor_op_nl-wiki
Comment 15 Quim Gil 2014-01-31 14:15:36 UTC
ca.wiki is also happy to test it, see https://ca.wikipedia.org/wiki/Viquip%C3%A8dia:La_taverna/Propostes#Activar_TemplateDataEditor
Comment 16 Ltrlg 2014-01-31 16:34:25 UTC
$wgTemplateDataUseGUI activates neither TemplateDataEditor nor TDSkell but TemplateDataGenerator. The two screenshots attached to this bug are for 'TemplateDataEditor' and 'TemplateData Editor', so the one you gave on cawiki is not correct.
Comment 17 Quim Gil 2014-01-31 17:38:58 UTC
As I said, the current information (or lack of) is confusing. Is there any wiki page or screenshot or anything we can link to?

In any case, ca.wiki wants to try it.  :)
Comment 18 Ltrlg 2014-01-31 20:01:37 UTC
Created attachment 14428 [details]
TemplateDataGenertor screenshot

I made a screenshot. I’ve cropped it to show only TemplateDataGenerator: it is a jQuery UI dialog centered on the screen.
Comment 19 James Forrester 2014-02-07 17:47:59 UTC
Follow-up in 60158.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links