Last modified: 2013-08-06 19:35:32 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T53086, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 51086 - Double newlines in blockquotes should be turned into paragraphs
Double newlines in blockquotes should be turned into paragraphs
Status: RESOLVED DUPLICATE of bug 6200
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: C. Scott Ananian
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-10 01:08 UTC by Roan Kattouw
Modified: 2013-08-06 19:35 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Roan Kattouw 2013-07-10 01:08:59 UTC
Wikitext:

<blockquote>
Foo

Bar
</blockquote>

Parsoid renders this as:
<blockquote data-parsoid='{"stx":"html","dsr":[0,35,12,13]}'>
<p data-parsoid='{"dsr":[13,16,0,0]}'>Foo</p>

<p data-parsoid='{"dsr":[18,21,0,0]}'>Bar</p>
</blockquote>

PHP renders this as:

<blockquote>
Foo

Bar
</blockquote>

which displays as "Foo Bar"
Comment 1 ssastry 2013-07-12 18:57:19 UTC
Ugh ... Tidy messes with us again.

<blockquote>
  foo
</blockquote>

In the test case above and the the one posted by Roan, parserTests specifies no outer p-wrapping, but Tidy adds an outermost p-wrapper inside blockquote (check in sandbox).  Only one p-tag is added around plain text insde blockquote independent of # of newlines.  Adding it will fail parser tests, and not adding it will not match Tidy's output.

So, should we or should we not add that single p-wrapper around text as a child of <blockquote>?
Comment 2 Gabriel Wicke 2013-07-12 19:22:40 UTC
The content semantics are really those with tidy, so whenever those make some sense we should follow them rather than broken PHP-only parser behavior. We can always mark the test Parsoid-only.
Comment 3 C. Scott Ananian 2013-07-12 21:41:17 UTC
Discussing this in IRC, we resolved that this was Not A Bug in Parsoid... but in fact the PHP parser should be changed to be consistent with parsoid (ie, double-newlines inside blockquotes should indicate division into paragraphs).
Comment 4 C. Scott Ananian 2013-08-06 16:53:52 UTC
This seems like it's a symptom of bug 6200.
Comment 5 C. Scott Ananian 2013-08-06 19:35:32 UTC

*** This bug has been marked as a duplicate of bug 6200 ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links