Last modified: 2013-10-07 23:03:40 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52722, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 50722 - VisualEditor: Can no longer access save dialog (cursor keys/backspace/etc.) if it ever loses focus
VisualEditor: Can no longer access save dialog (cursor keys/backspace/etc.) i...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2013-10-10
Assigned To: Rob Moen
:
: 52733 53332 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-04 07:35 UTC by Excirial
Modified: 2013-10-07 23:03 UTC (History)
23 users (show)

See Also:
Web browser: Firefox
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Excirial 2013-07-04 07:35:45 UTC
Steps to reproduce:

* Navigate to [[Mariposa botnet]] and edit the page in the visual editor.
* Make any textual change - just add "Test" somewhere for example.
* click "Save Page"
* Adding a reason doesn't matter. Just click to close the save page popup.
* Immediately open it again (Don't click anywhere else)
* Try to add a text as the reason, then press backspace or delete what you just added.

For some reason delete and backspace won't work anymore. My guess is that the backspace is send to the editing canvas instead of the textbox - try the following steps as well:

* (Do all the steps from the first section)
* Press "Review Your changes".
* Wait for the review to load, then press "Return To Save", and close the resulting form.
* Now click the search block (In mono) and enter a random search criteria.
* Once entered, try to remove it again.

What happens for me: Entering data in the search box works fine, but pressing backspace somehow causes text to be removed from the article, instead of the search box i was just typing in.
Comment 1 James Forrester 2013-07-07 01:06:08 UTC
Yes, this is a really horrible problem that we've narrowed-down to be related to ULS's munging of <textarea>s in Firefox (and possibly other browsers?). Referring to them.
Comment 2 Santhosh Thottingal 2013-07-07 12:12:47 UTC
By default input method from ULS is disabled in en.wikipedia.org. ie by default it does not do anything on textareas.

Even if it is enabled, there is no input method for English except IPA which optional. 

So in the case of the above bug, before mapping it to ULS component, please tell us whether input method was activated from the cog icon in the languages menu. Also let us know whether you were using IPA.

If this is not the case, the component is not ULS.

(In reply to comment #0)
> Steps to reproduce:
> 
> * Navigate to [[Mariposa botnet]] and edit the page in the visual editor.
> * Make any textual change - just add "Test" somewhere for example.
> * click "Save Page"
> * Adding a reason doesn't matter. Just click to close the save page popup.
> * Immediately open it again (Don't click anywhere else)

Open the the dialog for entering reason? It disappears after I click "Save Page". How do I open it again?
Comment 3 Excirial 2013-07-07 13:27:40 UTC
(In reply to comment #2)
> Open the the dialog for entering reason? It disappears after I click "Save
> Page". How do I open it again?

A bit more precise:
0) Navigate to [[Mariposa botnet]] and edit the page in the visual editor.
1) Make any textual change - just add "Test" somewhere for example.
2) Click "Save Page"
3) Now, the save page box titled "Save your changes" should pop up.
4) Close that box by clicking the ^ icon in the top right of that box.

Now, you should be where you started at step 2

5) Repeat steps 2 and 3
6) Try to add a text as the reason, then press backspace to delete what you just
added.
Comment 4 Santhosh Thottingal 2013-07-08 06:06:36 UTC
As per comment 2 and comment 3, changing the component back to VE.
Comment 5 vssun 2013-07-10 02:49:26 UTC
I think there is no connection with ULS for this bug. The bug exists at ml.wikipedia where no ULS is installed at present.
Comment 6 Siebrand Mazeland 2013-07-10 05:29:42 UTC
I updated the summary per comment 5.
Comment 7 James Forrester 2013-08-30 03:33:04 UTC
*** Bug 52733 has been marked as a duplicate of this bug. ***
Comment 8 James Forrester 2013-08-30 03:35:11 UTC
I believe that this is now fixed, having followed Chris's very helpful steps to reproduce in bug 52733 comment 1 - tested in Safari, Chrome and Firefox latest on Mac just now against wmf14 as deployed on the Wikipedias right now. Marking as such.

If you can re-produce, please feel free to re-open.
Comment 9 Chris McKenna 2013-08-30 20:59:27 UTC
I've just experienced this in my sandbox making this edit:
https://en.wikipedia.org/w/index.php?title=User%3AThryduulf%2Fsandbox&diff=570859913&oldid=570858997 (testing for bug 52399)

In this case the series of actions was:
1. Make some edits
2. Review changes
3. Return to editing surface (I can't remember whether I went direct using ^ or via the save form using <)
4. make some more edits
5. add an edit summary
6. review changes
7. return to save orm
8. attempt to amend edit summary, but encounter this bug
Comment 10 Chris McKenna 2013-08-30 21:28:43 UTC
Nearly simultaneously with my writing the above comment, en.wp user Tathbelin reported on the VE feedback page:

"I had the Problem that while I was writing my Change Summary after editing the page I wasn't able to delete what I had previously written i.e. couldn't use delete or backspace."

The edit in question was likely https://en.wikipedia.org/w/index.php?title=Henning_Wehn&diff=570856495&oldid=565884244
Comment 11 James Forrester 2013-08-30 21:54:01 UTC
(In reply to comment #9)
> I've just experienced this in my sandbox making this edit:
> https://en.wikipedia.org/w/index.
> php?title=User%3AThryduulf%2Fsandbox&diff=570859913&oldid=570858997
> (testing for bug 52399)
> 
> In this case the series of actions was:
> 1. Make some edits
> 2. Review changes
> 3. Return to editing surface (I can't remember whether I went direct using ^
> or via the save form using <)
> 4. make some more edits
> 5. add an edit summary
> 6. review changes
> 7. return to save orm
> 8. attempt to amend edit summary, but encounter this bug

With what browser?
Comment 12 Chris McKenna 2013-08-30 23:47:56 UTC
(In reply to comment #11)
> 
> With what browser?

I encountered it using Firefox 23 on linux, Tathbelin didn't note it in their report but I'll ask.

Sorry
Comment 13 James Forrester 2013-08-31 00:19:18 UTC
(In reply to comment #12)
> (In reply to comment #11)
> > 
> > With what browser?
> 
> I encountered it using Firefox 23 on linux, Tathbelin didn't note it in their
> report but I'll ask.
> 
> Sorry

OK, well, it works fine for me on enwiki right now in Firefox 23 on Mac and on Linux (doing the ^, the <, the Esc and the "return to save form" ways of bailing). This is perplexing. Do you have some odd gadgets loaded - does it still occur if you switch all gadgets off?
Comment 14 Chris McKenna 2013-08-31 00:36:05 UTC
I do have popups, hotcat and section edit link for the lead section installed. Plus a couple of other things a conversation on the feedback page the other day established as being on by default.

I tried to reproduce this when logged out, and couldn't.
I then logged back in and tried to reproduce it and again I couldn't, even with no changes to gadgets. I didn't try to replicate the exact edit I made though.

Earlier on today was the first time in a while I had experienced it though, which suggests to me that there is probably something more complicated behind when this happens and when it doesn't. I'll do some more detailed testing when I next get time, as it's too perplexing for 1:30am!
Comment 15 Gerrit Notification Bot 2013-09-04 20:13:47 UTC
Change 81876 had a related patch set uploaded by Jforrester:
Make the save dialog an actual dialog

https://gerrit.wikimedia.org/r/81876
Comment 16 Chris McKenna 2013-09-23 08:15:28 UTC
BeroBurns at en.wp today reported experiencing this bug:
"The save form does not allow for a keyboard backspace or to highlight text using Shift+Arrows. The only way to edit your description of the changes is to highlight the words you wish to replace with the mouse and retype."

I personally haven't encountered it since my comment above though.

What is the current state, it's had a patch waiting for review nearly 20 days and is still targetted for the release a month ago yesterday?
Comment 17 Chris McKenna 2013-09-23 16:27:21 UTC
*** Bug 53332 has been marked as a duplicate of this bug. ***
Comment 18 Chris McKenna 2013-09-23 16:34:13 UTC
At bug 53332 comment 0 Elias Hedberg notes that he encountered this bug while using Chrome 29.0.1547.57 running in OS X 10.6.8

Previously this seems only to have been encountered in Firefox. Will that affect the pending patch at all?
Comment 19 Gerrit Notification Bot 2013-10-07 23:01:51 UTC
Change 81876 merged by jenkins-bot:
Make the save dialog an actual dialog

https://gerrit.wikimedia.org/r/81876
Comment 20 James Forrester 2013-10-07 23:03:40 UTC
The (re)fix for this is now merged and will be deployed on Thursday 10 October to MediaWiki.org, and to Wikipedias on Thursday 17 October.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links