Last modified: 2013-09-04 16:11:55 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52310, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 50310 - wikibits: Wrap mwCustomEditButtons in mw.log.deprecate
wikibits: Wrap mwCustomEditButtons in mw.log.deprecate
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
JavaScript (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: 1.22.0 release
Assigned To: Alex Monk
: easy
Depends on:
Blocks: code_quality
  Show dependency tree / graph
 
Reported: 2013-06-27 18:27 UTC by Helder
Modified: 2013-09-04 16:11 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Helder 2013-06-27 18:27:39 UTC 
After reading bug 47872 comment 10 and looking for usage of mw.log.deprecate at
https://github.com/wikimedia/mediawiki-core/search?q=deprecate%28&type=Code
I believe the deprecation of "mwCustomEditButtons" is still to be done.

Creating this bug for that.
Comment 1 Krinkle 2013-06-27 18:34:05 UTC 
It has been deprecated for sure (it is overwhelmed in almost 3 layers of legacy and deprecation since at least MediaWiki 1.17), but mw.log.deprecate is a feature that has only existed for a short while.

This one should indeed be wrapped with a warning as well to make the deprecation easier to detect.

+1 :)
Comment 2 Alex Monk 2013-06-29 15:55:19 UTC 
If we use mw.log.deprecate on this then the warning will come up on every action=edit&debug=true page (even when no extension/user code is trying to use it) because of legacy support for it in mediawiki.action.edit.js. I don't know of any way to prevent that though...
Comment 3 Gerrit Notification Bot 2013-06-29 15:55:49 UTC 
Change 71176 had a related patch set uploaded by Alex Monk:
Deprecate mwCustomEditButtons

https://gerrit.wikimedia.org/r/71176
Comment 4 Bartosz Dziewoński 2013-06-29 18:49:39 UTC 
Per bug 47872 this currently doesn't work anyway, so the code in mediawiki.action.edit.js could be killed off, no?
Comment 5 Gerrit Notification Bot 2013-09-04 16:11:55 UTC 
Change 71176 merged by jenkins-bot:
Make mwCustomEditButtons a no-op and mark it as deprecated

https://gerrit.wikimedia.org/r/71176
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links