Last modified: 2014-11-19 19:04:19 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T51193, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 49193 - Add ContentHandler columns to Wikimedia wikis, and set $wgContentHandlerUseDB = true
Add ContentHandler columns to Wikimedia wikis, and set $wgContentHandlerUseDB...
Status: PATCH_TO_REVIEW
Product: Wikimedia
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Sean Pringle
:
Depends on: 70901 71163 73490
Blocks: 49188 62780 63885 70073 61255
  Show dependency treegraph
 
Reported: 2013-06-05 17:10 UTC by Greg Grossmeier
Modified: 2014-11-19 19:04 UTC (History)
12 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Greg Grossmeier 2013-06-05 17:10:37 UTC
Schema Change:

All wikis
tables: page, revision, archive 
changes:  Content handler columns 
commit status: merged

MediaWiki cannot operate without these columns (fatal error). But it can be disabled with wgContentHandlerUseDB (will be in wmf-production starting 1.21wmf2)

Disabled pre-emptively in CommonSettings.php --reedy 

Adding rev_content_format field to table revision...
Adding rev_content_model field to table revision...
Adding ar_content_format field to table archive...
Adding ar_content_model field to table archive...
Adding page_content_model field to table page...

gerrit change Id4e0f40c

https://meta.wikimedia.org/wiki/Wikidata/Notes/ContentHandler

http://lists.wikimedia.org/pipermail/wikitech-l/2012-March/059358.html
Comment 1 Greg Grossmeier 2013-07-09 21:27:32 UTC
Setting to enhancement/lowest as this is mostly a MediaWiki 2.0 thing :-)
Comment 2 Kunal Mehta (Legoktm) 2014-05-23 06:28:31 UTC
(In reply to Greg Grossmeier from comment #1)
> Setting to enhancement/lowest as this is mostly a MediaWiki 2.0 thing :-)

I don't think so. Flow and MassMessage will probably want/need to start using these fields soon, so it would be nice if we could get these columns added, or at least start the process. It's been about 3 MW versions now...
Comment 3 Greg Grossmeier 2014-06-10 18:18:47 UTC
Sean: Bumping priority a bit on this one because as legoktm just said on IRC:
"we're going to need it for Flow at some point and the MassMessage GSoC project which will be ready by the end of the summer"
Comment 4 Kunal Mehta (Legoktm) 2014-06-27 23:58:47 UTC
From June 11 SAL:  05:04 springle: beginning schema changes bug 49193 page_content_model
Comment 5 Kunal Mehta (Legoktm) 2014-08-02 01:36:18 UTC
<springle> legoktm: page_content_model done, ar_content_* started, rev_content_* todo
Comment 6 spage 2014-08-27 00:18:17 UTC
There have been a couple of implicit and explicit requests for this, so I added bug 63885 and bug 62780. And Flow needs it to improve the way we enable Flow on a page, bug 70073.

How will WMF roll out the second part (the $wgContentHandlerUseDB = true config change)?  We should test on Beta labs before production (InitialiseSettings-labs.php); will we then enable all production wikis at once or start with e.g. mediawikiwiki and the wikisource wikis whose users asked for it?
Comment 7 Kunal Mehta (Legoktm) 2014-08-27 03:36:34 UTC
$wgContentHandlerUseDB is already set to true on testwikidatawiki and wikidatawiki, so I think we can just turn it on once the schema changes are finished, no need to do it wiki by wiki,
Comment 8 Kunal Mehta (Legoktm) 2014-09-05 12:32:41 UTC
[05:29:18]  <springle>	 legoktm: s3 content model fields are complete

That'll let us turn it on testwiki, test2wiki, and mediawikiwiki to start with.
Comment 9 Gerrit Notification Bot 2014-09-08 17:30:26 UTC
Change 159089 had a related patch set uploaded by Legoktm:
Enable $wgContentHandlerUseDB on mediawikiwiki, testwiki, & test2wiki

https://gerrit.wikimedia.org/r/159089
Comment 10 Gerrit Notification Bot 2014-09-08 23:02:06 UTC
Change 159089 merged by jenkins-bot:
Enable $wgContentHandlerUseDB on mediawikiwiki, testwiki, & test2wiki

https://gerrit.wikimedia.org/r/159089
Comment 11 Kunal Mehta (Legoktm) 2014-09-09 00:48:30 UTC
Deployed by Erik, thanks!
Comment 12 Gerrit Notification Bot 2014-09-10 07:09:13 UTC
Change 159457 had a related patch set uploaded by Spage:
Set wgContentHandlerDB true for enwiki-labs

https://gerrit.wikimedia.org/r/159457
Comment 13 Gerrit Notification Bot 2014-09-16 18:17:58 UTC
Change 159457 merged by jenkins-bot:
Set wgContentHandlerDB true for enwiki-labs

https://gerrit.wikimedia.org/r/159457
Comment 14 Sean Pringle 2014-10-28 03:52:54 UTC
Schema change is done on all wikis.
Comment 15 Gerrit Notification Bot 2014-10-30 19:22:38 UTC
Change 170124 had a related patch set uploaded by Spage:
Typo in labs wgContentHandlerUseDB config

https://gerrit.wikimedia.org/r/170124
Comment 16 Gerrit Notification Bot 2014-10-30 19:35:41 UTC
Change 170129 had a related patch set uploaded by Spage:
$wgContentHandlerUseDB true everywhere

https://gerrit.wikimedia.org/r/170129
Comment 17 Gerrit Notification Bot 2014-11-04 13:21:37 UTC
Change 170124 merged by jenkins-bot:
Typo in labs wgContentHandlerUseDB config

https://gerrit.wikimedia.org/r/170124

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links