Last modified: 2006-06-15 20:01:07 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T6830, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 4830 - Spaces after links removed in some template expansions
Spaces after links removed in some template expansions
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: High major with 1 vote (vote)
: ---
Assigned To: Brion Vibber
http://en.wikipedia.org/w/index.php?t...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-02-02 00:19 UTC by Gdr
Modified: 2006-06-15 20:01 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Gdr 2006-02-02 00:19:27 UTC
See for example [[Rosales]]: in the "Families" section of the box at upper right, spaces are 
missing following links. For example, the wikitext "[[Urticaceae]] ([[nettle]] family)" has been 
rendered as Urticaceae(nettlefamily).

This doesn't happen in ordinary wikitext, only in the expansion of Template:Taxobox.

If the spaces are replaced by non-breaking space ( ) then the box renders correctly.
Comment 1 Gdr 2006-06-07 21:18:41 UTC
Any chance of this being fixed? It affects hundreds of articles. See http://en.wikipedia.org/w/
index.php?
title=Wikipedia_talk:WikiProject_Tree_of_Life&curid=1272975&diff=57416194&oldid=57415216 
for a complaint.
Comment 2 Brion Vibber 2006-06-07 21:28:52 UTC
Will take a look at this while I'm knee-deep in parser guts...
Comment 3 Gdr 2006-06-08 20:00:43 UTC
Thank you.
Comment 4 Brion Vibber 2006-06-09 11:03:37 UTC
The problem appears to be that the taxobox template uses a bogus
inner nested table that, when it comes down to it, looks like this:

{|
[[Cannabaceae]] ([[hemp]] family)
|}

Notice that there's no | to mark the text as being in a
table cell. The current wikitable parser is very lax about
this sort of thing, and renders it to bad HTML, something like:

<table>
<a href="/oneseven/index.php?title=Cannabaceae" title="Cannabaceae">Cannabaceae</a> (<a 
href="/oneseven/index.php?title=Hemp" title="Hemp">hemp</a> family)
<tr><td></td></tr></table>

HTML Tidy then tries to clean up the code; it notices the
inline text illegally placed into a <table> directly, and
moves it to a paragraph outside the table:

Tidy normalizes this to:
<p><a href="/oneseven/index.php?title=Cannabaceae" title="Cannabaceae">Cannabaceae</a>(<a 
href="/oneseven/index.php?title=Hemp" title="Hemp">hemp</a>family)</p>
<table>
<tr>
<td></td>
</tr>
</table>

Mysteriously it also removes the whitespace at the edge
of the link tags, but the construct is wrong to begin with
so it can't be faulted too much. :)

I've corrected the template:
http://en.wikipedia.org/w/index.php?title=Template:Taxobox&diff=57684420&oldid=56008320
Comment 5 Stacey Greenstein 2006-06-15 11:42:34 UTC
Brion, the change you made to the taxobox has made additional problems. If the
subdivision part of the box contains a bulleted list, the first asterisk does
not get wikified into a bullt. If the subdivision part contains a break-line
list, there is a gap between the first and second lines. See [[lemur]] and
[[Cheirogaleidae]] for examples respectively. - UtherSRG
Comment 6 Brion Vibber 2006-06-15 20:01:07 UTC
Then you'll need to fix those uses.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links