Last modified: 2014-11-15 12:22:42 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T49918, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 47918 - (global-user-merge) Rename of global (attached) users to existing global usernames
(global-user-merge)
Rename of global (attached) users to existing global usernames
Status: PATCH_TO_REVIEW
Product: MediaWiki extensions
Classification: Unclassified
CentralAuth (Other open bugs)
master
All All
: Normal normal with 1 vote (vote)
: ---
Assigned To: Kunal Mehta (Legoktm)
https://www.mediawiki.org/wiki/SUL_fi...
:
Depends on: 14862 39470 49518 67753 67754 67757 67761 67762 67763 67764 67766 67767 67769 67770 67771 67772 67773 67774 67775 67776 67777 67778 67780 67781 67782 67783 68844 70376 72204
Blocks: sulfinalization
  Show dependency treegraph
 
Reported: 2013-05-01 07:56 UTC by Nemo
Modified: 2014-11-15 12:22 UTC (History)
15 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Nemo 2013-05-01 07:56:10 UTC
Split from bug 14862.

Imagine A@global (composed of A@commonswiki and A@metawiki both attached),
B@global (composed of B@wikidatawiki and B@metawiki both attached), C@global
(composed only of C@mediawikiwiki).

Current situation (after bug 14862 is fixed) is that B and C can't be renamed to A. This means that all the users forcefully renamed for bug 35707 (if on more than one wiki) will have to request rename on Meta and only RenameUser will help. 

However, this means that all such accounts will be unattached and this is less than ideal beside being a pain for everyone involved. All such users will be in the case B because requesting rename creates a local account on Meta and A will probably have to confirm too.

What we need is:
* C can be renamed to A: C@global is deleted, the local account is
attached to A@global.
* B can be renamed to A: the wikidatawiki account is attached to A@global, while B@metawiki is left behind and B@global stays.
Comment 1 James Forrester 2013-05-01 16:54:39 UTC
This will already be achievable (but tedious) with the existing local RenameUser tool used by the stewards, as discussed. Marking as an enhancement. It also doesn't technically require Global Rename to be done (though we won't get to it until after that's merged).
Comment 2 Nemo 2013-05-01 16:56:56 UTC
(In reply to comment #1)
> This will already be achievable (but tedious) with the existing local
> RenameUser tool used by the stewards, as discussed.

No. RenameUser doesn't attach accounts.
Comment 3 James Forrester 2013-05-01 19:15:00 UTC
(In reply to comment #2)
> (In reply to comment #1)
> > This will already be achievable (but tedious) with the existing local
> > RenameUser tool used by the stewards, as discussed.
> 
> No. RenameUser doesn't attach accounts.

But stewards can detach accounts at will with the existing tools, and we can add the ability to attach non-clashing accounts to that relatively easily.
Comment 4 Nemo 2013-05-01 19:19:59 UTC
(In reply to comment #3)
> we can
> add the ability to attach non-clashing accounts to that relatively easily.

That ability was removed ages ago, IIRC; until it's restored, this is a bug.
Comment 5 Kunal Mehta (Legoktm) 2013-10-31 17:14:49 UTC
A bit confused as to what exactly is needed here...

(In reply to comment #0)
> What we need is:
> * C can be renamed to A: C@global is deleted, the local account is
> attached to A@global.

We can currently rename C@mediawikiwiki to A@mediawikiwiki, and I believe C@global will be automatically deleted since its empty (or a Steward can do it manually). So we would need some kind of interface for a steward to attach C@mediawikiwiki to C@global. 


> * B can be renamed to A: the wikidatawiki account is attached to A@global,
> while B@metawiki is left behind and B@global stays.

B@wikidatawiki can be renamed to A@wikidatawiki, which automatically separates it from the B@global account. We just need a way to automatically re-attach the new A@wikidatawiki to A@global.

So, the real request here is to create a special page for stewards to forcibly attach accounts to existing global ones. Is that correct?
Comment 6 Nemo 2013-10-31 17:24:37 UTC
(In reply to comment #5)
> A bit confused as to what exactly is needed here...

What do you mean with "currently" below? AFAIK bug 14862 is not fixed nor there is any global renaming feature as of now, just two patches in the works. This bug is about the proposed global rename feature, which in the basic requirements sed by James for bug 14862 would not allow to rename to an existing global username.
Comment 7 Kunal Mehta (Legoktm) 2013-10-31 17:30:53 UTC
(In reply to comment #6)
> (In reply to comment #5)
> > A bit confused as to what exactly is needed here...
> 
> What do you mean with "currently" below? AFAIK bug 14862 is not fixed nor
> there
> is any global renaming feature as of now, just two patches in the works. 

Your scenario in comment 0 was for global accounts with 1-2 local accounts, so stewards could just do local renames through the existing tools. When I said "currently", I meant what is possible right now.

> This
> bug is about the proposed global rename feature, which in the basic
> requirements sed by James for bug 14862 would not allow to rename to an
> existing global username.

I assume you're referring to bug 14862 comment 36.

I think I understand now. This is basically a request for some kind of merge account tool?
Comment 8 Nemo 2013-10-31 17:37:01 UTC
(In reply to comment #7)
> I think I understand now. This is basically a request for some kind of merge
> account tool?

Yes. The idea is that, after the great unification, all accounts will be unified, but some (or many) users will own several global accounts because of the forceful renames.
Comment 9 Gerrit Notification Bot 2014-07-14 05:51:23 UTC
Change 144644 had a related patch set uploaded by Legoktm:
Global merge tool

https://gerrit.wikimedia.org/r/144644
Comment 10 Gerrit Notification Bot 2014-09-02 20:33:16 UTC
Change 144644 merged by jenkins-bot:
Global merge tool

https://gerrit.wikimedia.org/r/144644
Comment 11 Kunal Mehta (Legoktm) 2014-09-02 23:20:40 UTC
The global merge tool has been merged, but in a disabled state. Next step is to update extensions that still aren't compatible with it (blockers).
Comment 12 Gerrit Notification Bot 2014-10-27 18:54:48 UTC
Change 169049 had a related patch set uploaded by Legoktm:
Enable global user merge on beta labs

https://gerrit.wikimedia.org/r/169049
Comment 13 Gerrit Notification Bot 2014-10-27 22:34:34 UTC
Change 169049 merged by jenkins-bot:
Enable global user merge on beta labs

https://gerrit.wikimedia.org/r/169049
Comment 14 Andre Klapper 2014-11-15 12:22:42 UTC
All patches mentioned in this report were merged or abandoned - is there more work left to do here (if yes: please reset the bug report status to NEW or ASSIGNED), or can you close this ticket as RESOLVED FIXED?

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links