Last modified: 2014-09-18 20:48:33 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T49520, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 47520 - overriding full-width input fields in Agora mw-ui-vform
overriding full-width input fields in Agora mw-ui-vform
Status: REOPENED
Product: MediaWiki
Classification: Unclassified
MediaWiki UI (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: design
Depends on:
Blocks: 70913
  Show dependency treegraph
 
Reported: 2013-04-22 21:55 UTC by spage
Modified: 2014-09-18 20:48 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
SimpleCaptcha looks wrong on signup page because not inline (38.93 KB, image/png)
2014-09-18 04:59 UTC, Matthew Flaschen
Details

Description spage 2013-04-22 21:55:00 UTC
The new Agora compact vertical form layout styles the selector ".mw-ui-vform > div input" as "display: block", turning all input fields within divs full-width.

This isn't be appropriate for some input fields, e.g. the simple captcha looks better with the input field inline and smaller
   88+5 = [        ]

To fix this we could add a mw-ui-inline "reset" style, or we could make the selector only style input fields that are immediate children of the div full-width, i.e. ".mw-ui-vform > div > input".  It's hard to know which approach is better until there are more clients of the form.
Comment 1 spage 2013-04-22 22:18:55 UTC
A downside of a reset style is it's less specific, so it either must replicate the complex selector or use the frowned-upon !important, thus:
  .mw-vforms-captcha {
    display: inline !important;
    width: auto !important;
  }
Comment 2 Matthew Flaschen 2013-04-22 22:28:35 UTC
You can use http://specificity.keegan.st/ to figure out a way to beat the specificity.  Granted, that doesn't necessarily make it any more readable than !important.
Comment 3 Jon 2014-08-28 18:59:32 UTC
I'm not sure I understand this bug in the current context. Can you please update with a 2014 version of this bug report?
Comment 4 Jon 2014-09-04 12:01:29 UTC
Please document bug 69449. This bug and the vform elements are not well described. I will mark as INVALID if I don't hear back within a week.
Comment 5 Matthew Flaschen 2014-09-18 04:57:26 UTC
Sorry for not replying earlier.

This is not invalid in my opinion.  The bug is easy to reproduce (in 2014), by setting the CAPTCHA type to SimpleCaptcha as stated in the initial report.

The first field (see screenshot I'm about to attach) should be on the same line as the math equation (the answer to the CAPTCHA is the right side of the Math equation).

Thus, there should be a way to specify this field behavior, so it can be used here among (probably) other places.
Comment 6 Matthew Flaschen 2014-09-18 04:59:02 UTC
Created attachment 16510 [details]
SimpleCaptcha looks wrong on signup page because not inline
Comment 7 Matthew Flaschen 2014-09-18 06:46:11 UTC
May be fixable with mw-ui-input-inline
Comment 8 Prateek Saxena 2014-09-18 20:42:58 UTC
This should get fixed once bug 70974 and bug 70973 are resolved.
Comment 9 Prateek Saxena 2014-09-18 20:48:33 UTC
Sorry, ignore my last comment. Unrelated.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links