Last modified: 2013-04-08 20:55:59 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T49018, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 47018 - Master broken (jsduck)
Master broken (jsduck)
Status: VERIFIED FIXED
Product: Wikimedia
Classification: Unclassified
Continuous integration (Other open bugs)
wmf-deployment
All All
: Immediate blocker (vote)
: ---
Assigned To: Antoine "hashar" Musso (WMF)
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-04-08 18:54 UTC by Bartosz Dziewoński
Modified: 2013-04-08 20:55 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Bartosz Dziewoński 2013-04-08 18:54:48 UTC 
Master is failing jenkins tests right now due to some JSDuck failures.

Examples: https://gerrit.wikimedia.org/49364 , https://gerrit.wikimedia.org/r/57922
Comment 1 Gerrit Notification Bot 2013-04-08 19:04:33 UTC 
Related URL: https://gerrit.wikimedia.org/r/58131 (Gerrit Change I2d945b7ffb7cfbcc5024a1c3bdcf0c9506b0cf76)
Comment 2 Antoine "hashar" Musso (WMF) 2013-04-08 19:05:19 UTC 
Most probably caused by https://gerrit.wikimedia.org/r/#/c/56637/ that has been force merged.

Revert is https://gerrit.wikimedia.org/r/#/c/58131/
Comment 3 Roan Kattouw 2013-04-08 19:08:40 UTC 
Maybe the V+2 and submit rights should be taken away from human users for core? We did this in VisualEditor a few months ago.
Comment 4 Chad H. 2013-04-08 19:12:32 UTC 
(In reply to comment #3)
> Maybe the V+2 and submit rights should be taken away from human users for
> core?
> We did this in VisualEditor a few months ago.

+10, best idea ever
Comment 5 Antoine "hashar" Musso (WMF) 2013-04-08 19:24:41 UTC 
Changed merged by Jenkins, so that definitely fixed the issue :-]
Comment 6 Antoine "hashar" Musso (WMF) 2013-04-08 20:55:59 UTC 
Original patch has been resubmitted by Roan with https://gerrit.wikimedia.org/r/#/c/58134/ . That new version passed the JSDuck job \O/
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links