Last modified: 2014-09-01 15:53:05 UTC
Vector first reverses the order of horizontal nav elements in HTML and then prevents flipping of float:left rules in CSS to make the interface looks the same in LTR and RTL environments. Similar craziness is done to the search form - the input and the button are rendered in different order in LTR and RTL. This causes e.g. bug 34587. Vector.php: // Reverse horizontally rendered navigation elements if ( $this->data['rtl'] ) { $this->data['view_urls'] = array_reverse( $this->data['view_urls'] ); $this->data['namespace_urls'] = array_reverse( $this->data['namespace_urls'] ); $this->data['personal_urls'] = array_reverse( $this->data['personal_urls'] ); } ... // If there's a series of elements, reverse them when in RTL mode } elseif ( $this->data['rtl'] ) { $elements = array_reverse( $elements ); } ... etc vector/screen.css: /* @noflip */ div.vectorTabs { float: left; height: 2.5em; } ... /* @noflip */ div.vectorTabs ul { float: left; } ... etc Why would anyone do that is just mind-boggling to me. I assume it's a workaround for some IE6 bugs.
You should be careful to check, but this should be something we can get rid of now because it was actually an IE 5.5 workaround, and we no longer need to provide support for that browser since it's below the 0.1% market share threshold (currently at 0.05%) according to http://stats.wikimedia.org/wikimedia/squids/SquidReportClients.htm Monobook in IE 5.5 would simply display the tabs in the wrong order - but I wasn't willing to accept that for Vector, so I ended up with this hack. Let's verify it's ok to remove for IE 6, and if all looks clear, get rid of this.
Change 82100 had a related patch set uploaded by Matmarex: Rewrite rendering of Vector simple search https://gerrit.wikimedia.org/r/82100
(The patch above only pokes with the search, not with the navigation.)
This is definitely correct, important and needed. After this is fixed I should revert this https://commons.wikimedia.org/w/index.php?title=MediaWiki:Gadget-MyUploads.js&diff=101977822&oldid=101398730 so please fix it soon
Change 82100 merged by jenkins-bot: Rewrite rendering of Vector simple search https://gerrit.wikimedia.org/r/82100