Last modified: 2014-02-12 23:38:15 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T47914, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 45914 - [CODE QUALITY] Refactor the storage of "trust" information in the user properties (use JSON)
[CODE QUALITY] Refactor the storage of "trust" information in the user proper...
Status: ASSIGNED
Product: MediaWiki extensions
Classification: Unclassified
OpenID (Other open bugs)
master
All All
: Low enhancement (vote)
: ---
Assigned To: T. Gries
:
Depends on:
Blocks: 9604 45323
  Show dependency treegraph
 
Reported: 2013-03-08 22:44 UTC by T. Gries
Modified: 2014-02-12 23:38 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description T. Gries 2013-03-08 22:44:15 UTC
Currently, the information of trusted sites is stored in an usual way. Should be changed to serialized or better, simply to JSON, fully.

The relevant parts which needs to be changed are in

+ SpecialOpenIDServer.body.php

	# Get the user's configured trust value for a particular trust root.
	# Returns one of three values:
	# * NULL -> no stored trust preferences
	# * false -> stored trust preference is not to trust
	# * array -> possibly empty array of allowed profile fields; trust is OK

	function GetUserTrust( $user, $trust_root ) {

	function SetUserTrust( &$user, $trust_root, $value ) {

	static function GetUserTrustArray( $user ) {

	function SetUserTrustArray( &$user, $arr ) {


Blocks https://bugzilla.wikimedia.org/show_bug.cgi?id=45323
Comment 1 T. Gries 2013-03-08 22:44:50 UTC
blocks deployment
Comment 2 T. Gries 2013-11-24 11:18:58 UTC
The trust data is already JSON-encoded (encapsulated) stored and respectively retrieved using

+ $user->setOption( 'openid_trust', FormatJSON::encode( $trust_str ) ); ) 

in SpecialOpenIDServer.body.php.

So this bug is of minor importance - no need to fix this with priority (setting => low importance)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links