Last modified: 2013-06-05 15:23:04 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T47697, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 45697 - Google Maps not working with https


Summary:	Google Maps not working with https

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	Maps (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Unprioritized normal (vote)
Target Milestone:	---
Assigned To:	Niklas Laxström

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	39480
	Show dependency tree / graph

Reported:	2013-03-04 13:35 UTC by Niklas Laxström
Modified:	2013-06-05 15:23 UTC (History)
CC List:	3 users (show)

See Also:	44224
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Niklas Laxström 2013-03-04 13:35:48 UTC

[blocked] The page at https://translatewiki.net/w/i.php?title=User:Amire80&action=formedit&debug=true ran insecure content from http://maps.googleapis.com/maps/api/js?language=fi&sensor=false.

Comment 1 Nemo 2013-03-04 13:42:19 UTC

Does this also mean that bug 44224 comment 2 would not help? (Maps have been broken for a couple months now on translatewiki.net.)

Comment 2 Jeroen De Dauw 2013-03-04 19:38:35 UTC

If you allow saving via both http and https, then the saved content will have the link for the protocol with which it was saved. Known issue, some bug exists for this already.

Comment 3 Niklas Laxström 2013-03-04 20:29:05 UTC

Where is the code? Is it enough to just make sure that protocol relative url is saved?

Comment 4 Jeroen De Dauw 2013-03-04 20:31:48 UTC

Looks like it is in MapsGoogleMaps3::getApiScript.

Do protocol relative URLs work in older browsers?

Comment 5 Niklas Laxström 2013-03-04 20:41:43 UTC

All major browsers do support them. I'm unable to find definite resources on this, but MediaWiki uses protocol relative urls a lot without any reported issues that I am aware of.

Comment 6 Nemo 2013-03-04 20:44:40 UTC

Relevant quip: 
[Relative URIs] They're not not recommended, it just says their usage is rare. Which is a statement that was true in '05, and which we made false in '11. –RoanKattouw

Comment 7 Jeroen De Dauw 2013-03-04 22:24:05 UTC

Well, by any means go ahead and change it then.

Comment 8 Niklas Laxström 2013-03-05 10:13:56 UTC

Funny that after changing that it now says "Your browser is not compatible with Google Maps v3." even though I'm using the latest Chrome.

Comment 9 Niklas Laxström 2013-03-05 10:14:47 UTC

https://gerrit.wikimedia.org/r/52220

Comment 10 Jeroen De Dauw 2013-03-06 00:51:15 UTC

> Funny that after changing that it now says "Your browser is not compatible with
> Google Maps v3." even though I'm using the latest Chrome.

That will happen when the Google Maps API code does not get loaded. Is this the case after your changes? Seems to work fine for me, in both ff and chromium.

Comment 11 Andre Klapper 2013-06-05 13:53:52 UTC

(In reply to comment #9 by Niklas Laxström)
> https://gerrit.wikimedia.org/r/52220

Merged three months ago. Is this bug report FIXED or is there more to do?

Comment 12 Nemo 2013-06-05 15:23:04 UTC

(In reply to comment #11)
> Merged three months ago. Is this bug report FIXED or is there more to do?

The URL works correctly, with everything loaded securely from googleapis.com and no errors in dev tools, as of Chromium 25.0. I've not seen problems with our maps in the last weeks/months, so I think this can be closed.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links