Last modified: 2014-08-20 15:54:08 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 45145 - Load editing toolbar on element ready instead of content ready
Load editing toolbar on element ready instead of content ready
Status: NEW
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: javascript, performance
: 45144 (view as bug list)
Depends on:
Blocks: edit-toolbar
  Show dependency treegraph
Reported: 2013-02-19 04:48 UTC by Isarra
Modified: 2014-08-20 15:54 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Description Isarra 2013-02-19 04:48:09 UTC
Apparently the editing toolbar currently loads on content ready after the entire page finishes loading. Since said entire page can take quite awhile and people often want to start editing before that and the toolbar moves the textarea down when it loads, as well as potentially otherwise messing up anyone who has already tried to start editing, it should really be loading as soon as the relevant stuff is ready instead of waiting for everything else too.
Comment 1 Krinkle 2013-02-19 06:50:56 UTC
Just curious, what exactly is the "rest" of the page on EditAction after the main <textarea> before </html>?

Afaik the output between those two points in the output are a straight forward buffer output, no additional expensive or slow actions (e.g. "templates used" is calculated before hand).

From EditPage::showEditForm:
- edit toolbar
- showTextbox1
- standard inputs
- edit tools
- templates used
- (hidden) categories

Also, the WikiEditor extension itself loads from the bottom queue, which is asynchronous and doesn't block the document-ready event so basically everything executes straight away already.

There is certainly room for optimisation, but it's not as simple as changing the $(document).ready binding to something else.
Comment 2 Isarra 2013-02-19 07:01:15 UTC
This bug is not about the WikiEditor toolbar (that one's Bug 45144), but the normal one that ships with core.

Now what you said may be the case with the regular editing toolbar too, but frankly all I really know is both of them wait to activate and that causes problems for people.
Comment 3 Nemo 2014-06-01 06:59:15 UTC
It's true that this happens. For me it's much rarer than in WikiEditor (where it's certain to happen + bug 41911), but this is no indication of how common it may be.
Comment 4 Bartosz Dziewoński 2014-08-20 15:54:08 UTC
*** Bug 45144 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.