Last modified: 2014-01-31 20:36:00 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T46915, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 44915 - EditPage.php assumes mediawiki.action.edit module present (breaks mobile)
EditPage.php assumes mediawiki.action.edit module present (breaks mobile)
Status: RESOLVED WORKSFORME
Product: MediaWiki
Classification: Unclassified
Page editing (Other open bugs)
1.21.x
All All
: High normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on: 28856
Blocks:
  Show dependency tree / graph
 
Reported: 2013-02-12 19:57 UTC by Jon
Modified: 2014-01-31 20:36 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Jon 2013-02-12 19:57:08 UTC 
In mobile this module is NOT present so this throws a javascript exception.

Currently a dependency is made in EditPage.php itself to add toolbar related code. This should be added as a separate module rather than an inline script.

  $script = 'mw.loader.using("mediawiki.action.edit", function() {';

getEditToolbar should not run any javascript - it should simply add html that is enhanced by a javascript module. An inline script does not seem to be necessary here.
Comment 1 Jon 2013-02-13 06:26:52 UTC 
This horrible hack has got the functionality working in mobile for the time being:
https://gerrit.wikimedia.org/r/#/c/48663/2/includes/skins/SkinMobile.php
Comment 2 Helder 2014-01-30 17:59:53 UTC 
Will this be fixed once the code is moved out of core? (bug 28856)
Comment 3 Jon 2014-01-31 20:36:00 UTC 
Mobile now completely overrides the edit action so this is no longer an issue here.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links