Last modified: 2013-07-25 07:07:56 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T46010, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 44010 - Notice about page move appears in a wrong language in the page history
Notice about page move appears in a wrong language in the page history
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UniversalLanguageSelector (Other open bugs)
master
All All
: High normal (vote)
: ---
Assigned To: Niklas Laxström
:
Depends on:
Blocks: uls-deployment
  Show dependency treegraph
 
Reported: 2013-01-15 19:42 UTC by MF-Warburg
Modified: 2013-07-25 07:07 UTC (History)
11 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description MF-Warburg 2013-01-15 19:42:52 UTC
See https://incubator.wikimedia.org/w/index.php?title=Wy/cy/Hafan&action=history

(cur | prev) 19:57, 15 January 2013‎ Leinbach (Talk | contribs | block)‎ m . . (3,986 bytes) (0)‎ . . (Leinbach переименовал страницу Wy/cy в Wy/cy/Hafan: of course if you done it) (undo)
Comment 1 Robin Pepermans (SPQRobin) 2013-01-15 19:45:54 UTC
It appears in the user language, to be more precise, instead of the wiki content language.

And the message is logentry-move-move.
Comment 2 Robin Pepermans (SPQRobin) 2013-01-15 19:59:48 UTC
The bug is present only when UniversalLanguageSelector is enabled on the wiki.
Comment 3 Nemo 2013-01-15 20:19:30 UTC
I noted this earlier today in https://www.mediawiki.org/w/index.php?title=Manual:Pywikipediabot/id&action=history
Note that the entry is in Italian even though I'm using English as interface language, both in my preferences and according to ULS, now and then.
Comment 4 Siebrand Mazeland 2013-01-15 20:29:50 UTC
I'll ask Niklas to look into this when the European workday starts on Wednesday.
Comment 5 Siebrand Mazeland 2013-01-15 21:13:29 UTC
Initial response by Niklas is: "ULS can't break that stuff"

So please provide some proof that this is caused by UniversalLanguageSelector. If it's not related, we'll at least try to find out what's causing it and notify.
Comment 6 Robin Pepermans (SPQRobin) 2013-01-15 21:21:31 UTC
I tested this on a wiki with ULS enabled, and the bug was present for entries created then. I disabled ULS, and I moved a page and the bug did not appear for that entry, so I assumed ULS is somehow the cause.
Comment 7 Nemo 2013-01-15 21:31:53 UTC
I tried to test this on test2wiki but it's still on wmf7; on beta labs I get a fatal error which prevents me to save; testwiki, mw.o, meta and wikidata all have ULS, as well as TWN and its subdomains... How to test without a testing infrastructure???
Comment 8 Niklas Laxström 2013-01-16 10:02:40 UTC
There were two issues in language object construction in RequestContext::newExtranousContext:
* ULS was always using global request context because correct context was not given
* Even when I passed request context, cookie data from the primary context was leaking.

Fix in ULS:
https://gerrit.wikimedia.org/r/44231

Fixes in core (should imho be backported to 1.19 and 1.20):
https://gerrit.wikimedia.org/r/44226
https://gerrit.wikimedia.org/r/44227

Since deploying is in a funky state now I ask for help deploying these fixes once they have been reviewed.
Comment 9 Alex Monk 2013-01-28 17:16:55 UTC
(In reply to comment #8)
> Fix in ULS:
> https://gerrit.wikimedia.org/r/44231
> 
> Fixes in core (should imho be backported to 1.19 and 1.20):
> https://gerrit.wikimedia.org/r/44226
> https://gerrit.wikimedia.org/r/44227
> 
> Since deploying is in a funky state now I ask for help deploying these fixes
> once they have been reviewed.

These are all merged now. Is this bug fixed?
Comment 10 Nemo 2013-01-28 17:47:13 UTC
It's fixed but not yet backported to 1.19 and 1.20.
http://dev.translatewiki.net/w/i.php?title=User%3ANemo_bis%2FBug_44010&diff=4398081&oldid=4398080

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links