Last modified: 2014-06-04 02:59:45 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 43911 - Special:Undelete fails when too many checkboxes are checked
Special:Undelete fails when too many checkboxes are checked
Status: NEW
Product: MediaWiki
Classification: Unclassified
Page deletion (Other open bugs)
1.22.0
All All
: Normal normal with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-01-12 20:08 UTC by Matt Cole
Modified: 2014-06-04 02:59 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Undelete page-before issue (176.17 KB, image/png)
2013-01-13 07:23 UTC, Matt Cole
Details
Undelete page-after issue (83.70 KB, image/png)
2013-01-13 07:23 UTC, Matt Cole
Details

Description Matt Cole 2013-01-12 20:08:31 UTC
Special:Undelete fails when more than X revisions are checked.  So far, the lowest number I've been able to put on X is about 3,100.  When I click on "Restore", the page acts as if it hadn't received any of the request data at all -- e.g., if you go to http://en.wikipedia.org/wiki/Special:Undelete, that's exactly what I see.  Received this issue with both Chrome 23.0.1271.97m and IE9.
Comment 1 Matt Cole 2013-01-13 07:23:29 UTC
Created attachment 11621 [details]
Undelete page-before issue
Comment 2 Matt Cole 2013-01-13 07:23:50 UTC
Created attachment 11622 [details]
Undelete page-after issue
Comment 3 Matt Cole 2013-01-13 07:24:13 UTC
Attaching screenshots for a test case with [[en:Gjirokastër]].
Comment 4 Andre Klapper 2013-01-14 10:53:07 UTC
Thanks for taking the time to report this!
Comment 5 Jesús Martínez Novo (Ciencia Al Poder) 2013-01-27 18:03:40 UTC
I think this happens because we're hitting the PHP max_input_vars limit [1].

Have you tried to mark only the revisions you don't want to restore and use the "invert selection" button instead of mark the ones you want to restore? That will lower the number of variables sent to the server (if they're less than the revisions to restore) and allow you to restore the page.

But anyway, the Special:Undelete needs pagination, and I've filled bug 44410 about that.

----

[1] http://www.php.net/manual/info.configuration.php#ini.max-input-vars
Comment 6 Matt Cole 2013-01-28 15:45:17 UTC
Yes, I have, but that button only invokes JavaScript code that simply inverts the checked status of all the checkboxes on that page -- it doesn't send a request to the server to invert the selection.
Comment 7 Jesús Martínez Novo (Ciencia Al Poder) 2013-01-28 20:07:55 UTC
Whoops! I haven't tested it, I just inspected the HTML and saw that it was a input[type="submit"], so I assumed it was doing a server-side action.

It seems a sensible fix for this.
Comment 8 Graham87 2013-04-23 11:03:20 UTC
This bug was discussed in this thread on the technical village pump:
http://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Bug_in_undeleting_2_pages_with_many_edits
Comment 9 Scott Martin (http://enwp.org/user:scott) 2014-04-13 15:07:34 UTC
I encountered this bug attempting to undelete a page with approximately 1100 revisions.
Comment 10 king.of.hearts.wiki 2014-06-04 02:59:45 UTC
I was trying to undelete Denise Donnelly with about 1800 revisions. (I have since been able to successfully undelete it in pieces and moved it to Involuntary celibacy.)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links